You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Xiang Yang (Code Review)" <ge...@cloudera.org> on 2023/02/22 14:12:38 UTC
[Impala-ASF-CR] IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
Xiang Yang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19527
Change subject: IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
......................................................................
IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
Testing:
- add BE test 'ClusterMembershipMgrTest.IsBlacklisted'.
Change-Id: Ib35f5ee1f4c54b2acd62e737ca250f8814e87450
---
M be/src/scheduling/cluster-membership-mgr-test.cc
M be/src/scheduling/executor-blacklist.cc
2 files changed, 24 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/19527/1
--
To view, visit http://gerrit.cloudera.org:8080/19527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib35f5ee1f4c54b2acd62e737ca250f8814e87450
Gerrit-Change-Number: 19527
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Yang <yx...@126.com>
[Impala-ASF-CR] IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19527 )
Change subject: IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9064/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib35f5ee1f4c54b2acd62e737ca250f8814e87450
Gerrit-Change-Number: 19527
Gerrit-PatchSet: 3
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 17:53:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
Posted by "Xiang Yang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19527
to look at the new patch set (#2).
Change subject: IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
......................................................................
IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
Testing:
- add BE test 'ClusterMembershipMgrTest.IsBlacklisted'.
Change-Id: Ib35f5ee1f4c54b2acd62e737ca250f8814e87450
---
M be/src/scheduling/cluster-membership-mgr-test.cc
M be/src/scheduling/executor-blacklist.cc
2 files changed, 25 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/19527/2
--
To view, visit http://gerrit.cloudera.org:8080/19527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib35f5ee1f4c54b2acd62e737ca250f8814e87450
Gerrit-Change-Number: 19527
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19527 )
Change subject: IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19527/1/be/src/scheduling/cluster-membership-mgr-test.cc
File be/src/scheduling/cluster-membership-mgr-test.cc:
http://gerrit.cloudera.org:8080/#/c/19527/1/be/src/scheduling/cluster-membership-mgr-test.cc@371
PS1, Line 371: EXPECT_TRUE(backends_[0]->cmm->GetSnapshot()->executor_blacklist.IsBlacklisted(*(backends_[1]->desc)));
line too long (105 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/19527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib35f5ee1f4c54b2acd62e737ca250f8814e87450
Gerrit-Change-Number: 19527
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 14:13:29 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19527 )
Change subject: IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12417/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib35f5ee1f4c54b2acd62e737ca250f8814e87450
Gerrit-Change-Number: 19527
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 14:32:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19527 )
Change subject: IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12419/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib35f5ee1f4c54b2acd62e737ca250f8814e87450
Gerrit-Change-Number: 19527
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 14:59:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19527 )
Change subject: IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
......................................................................
IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
Testing:
- add BE test 'ClusterMembershipMgrTest.IsBlacklisted'.
Change-Id: Ib35f5ee1f4c54b2acd62e737ca250f8814e87450
Reviewed-on: http://gerrit.cloudera.org:8080/19527
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/scheduling/cluster-membership-mgr-test.cc
M be/src/scheduling/executor-blacklist.cc
2 files changed, 25 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib35f5ee1f4c54b2acd62e737ca250f8814e87450
Gerrit-Change-Number: 19527
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19527 )
Change subject: IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib35f5ee1f4c54b2acd62e737ca250f8814e87450
Gerrit-Change-Number: 19527
Gerrit-PatchSet: 3
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 17:53:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19527 )
Change subject: IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
......................................................................
Patch Set 2: Code-Review+2
It makes sense to me. Thanks for fixing this.
--
To view, visit http://gerrit.cloudera.org:8080/19527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib35f5ee1f4c54b2acd62e737ca250f8814e87450
Gerrit-Change-Number: 19527
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 17:52:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19527 )
Change subject: IMPALA-11931: enhance ExecutorBlacklist::IsBlacklisted to avoid null pointer exception
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19527
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib35f5ee1f4c54b2acd62e737ca250f8814e87450
Gerrit-Change-Number: 19527
Gerrit-PatchSet: 3
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Feb 2023 23:02:58 +0000
Gerrit-HasComments: No