You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/12/18 14:05:26 UTC

[GitHub] wu-sheng commented on a change in pull request #2064: Fix application cannot start when the dubbo interface with @RequestMapping

wu-sheng commented on a change in pull request #2064: Fix application cannot start when the dubbo interface with @RequestMapping
URL: https://github.com/apache/incubator-skywalking/pull/2064#discussion_r242548233
 
 

 ##########
 File path: apm-sniffer/optional-plugins/pom.xml
 ##########
 @@ -43,6 +43,7 @@
     <modules>
         <module>optional-spring-plugins</module>
         <module>trace-ignore-plugin</module>
+        <module>dubbo-patch</module>
 
 Review comment:
   `dubbo-patch` looks like a strange name. Does this plugin try to resolve dubbo-springmvc conflict? If I am right, please name it `dubbo-springmvc-confict-patch`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services