You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/18 09:10:17 UTC

[GitHub] [flink] MartijnVisser opened a new pull request, #19764: [FLINK-27680][Connector][Pulsar] Disable PulsarSinkITCase and PulsarSourceITCase on JDK 11

MartijnVisser opened a new pull request, #19764:
URL: https://github.com/apache/flink/pull/19764

   ## What is the purpose of the change
   
   * Disable Pulsar tests on JDK 11 since Pulsar doesn't yet support JDK 11 fully
   
   ## Brief change log
   
   * Disabled tests
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: (no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19764: [FLINK-27680][Connector][Pulsar] Disable PulsarSinkITCase and PulsarSourceITCase on JDK 11

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19764:
URL: https://github.com/apache/flink/pull/19764#issuecomment-1129769041

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a4829e0508aa032cf1f57f4809d9c26798338ae8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a4829e0508aa032cf1f57f4809d9c26798338ae8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a4829e0508aa032cf1f57f4809d9c26798338ae8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #19764: [FLINK-27680][Connector][Pulsar] Disable PulsarSinkITCase and PulsarSourceITCase on JDK 11

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #19764:
URL: https://github.com/apache/flink/pull/19764#issuecomment-1129805250

   > I would wonder why we would risk failing Flink's CI on something that we know that Pulsar doesn't support
   
   Because the issue may not be related to java 11 in the first place. The tests are unstable on Java 8 as well.
   
   > We also disabled other Pulsar test on Java 11 (PulsarSourceOrderedE2ECase)
   
   That's something different though; there we dealt with missing JDK dependencies. Actually I'm not sure why we disabled it in the first place, given that we supposedly fixed the dependency issue in the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #19764: [FLINK-27680][Connector][Pulsar] Disable PulsarSinkITCase and PulsarSourceITCase on JDK 11

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19764:
URL: https://github.com/apache/flink/pull/19764#issuecomment-1129779890

   > Do we actually know what is causing the issue? The PulsarSinkITCase seems to work just fine, and the tests passed in general in the past on Java 11.
   
   We don't. Then again, Pulsar doesn't support yet Java 11, so I would wonder why we would risk failing Flink's CI on something that we know that Pulsar doesn't support. We also disabled other Pulsar test on Java 11 (`PulsarSourceOrderedE2ECase`)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser merged pull request #19764: [FLINK-27680][Connector][Pulsar] Disable PulsarSinkITCase and PulsarSourceITCase on JDK 11

Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #19764:
URL: https://github.com/apache/flink/pull/19764


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #19764: [FLINK-27680][Connector][Pulsar] Disable PulsarSinkITCase and PulsarSourceITCase on JDK 11

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #19764:
URL: https://github.com/apache/flink/pull/19764#issuecomment-1129773795

   Do we actually know what is causing the issue?
   The PulsarSinkITCase seems to work just fine, and the tests passed in general in the past on Java 11.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #19764: [FLINK-27680][Connector][Pulsar] Disable PulsarSinkITCase and PulsarSourceITCase on JDK 11

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19764:
URL: https://github.com/apache/flink/pull/19764#issuecomment-1129950651

   > Because the issue may not be related to java 11 in the first place. The tests are unstable on Java 8 as well.
   
   Agreed. But even if they were stable on Java 8, I would still prefer to disable them on Java 11. We know the support isn't there and even if it runs OK, there's no guarantee that at some point in time it could break (because we might change something in Flink which then causes the test to fail). In the end, only the Pulsar maintainers can fix this problem and I think we should disable any Pulsar test on Java 11. 
   
   > That's something different though; there we dealt with missing JDK dependencies. Actually I'm not sure why we disabled it in the first place, given that we supposedly fixed the dependency issue in the PR.
   
   According to the PR which introduced it https://github.com/apache/flink/pull/18815 the reason was `Disable the PulsarSourceOrderedE2ECase test on Java 11 for direct buffer memory error.`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org