You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by bu...@apache.org on 2006/02/15 07:24:46 UTC

DO NOT REPLY [Bug 38649] New: - [pool] Generic[Keyed]ObjectPool.ObjectTimestampPair can be static and can be shared

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38649>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38649

           Summary: [pool] Generic[Keyed]ObjectPool.ObjectTimestampPair can
                    be static and can be shared
           Product: Commons
           Version: unspecified
          Platform: All
               URL: http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper
                    /pool/trunk/src/java/org/apache/commons/pool/impl/
        OS/Version: All
            Status: NEW
          Keywords: PatchAvailable
          Severity: enhancement
          Priority: P4
         Component: Pool
        AssignedTo: commons-dev@jakarta.apache.org
        ReportedBy: Sandy@McArthur.org


The GenericObjectPools both have a package scoped inner class named
ObjectTimestampPair. This inner class can be static, which saves a reference
back to it's parent class and a very small bit of overhead. Once they are static
then the same implementation can be shared between the two GenericObjectPools.
This patch does just that. Since ObjectTimestampPair inner class is package
scoped this won't have any affect on API compatability.

FindBugs http://findbugs.sourceforge.net/ deserves credit for detecting that the
inner class could be static.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org

DO NOT REPLY [Bug 38649] - [pool] Generic[Keyed]ObjectPool.ObjectTimestampPair can be static and can be shared

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38649>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38649


rdonkin@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From rdonkin@apache.org  2006-02-18 18:22 -------
Committed. Many thanks.

Maybe it'd be worth making the class final one day.

Robert

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org

DO NOT REPLY [Bug 38649] - [pool] Generic[Keyed]ObjectPool.ObjectTimestampPair can be static and can be shared

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38649>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38649





------- Additional Comments From Sandy@McArthur.org  2006-02-15 07:25 -------
Created an attachment (id=17701)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=17701&action=view)
GenericObjectPools-ObjectTimestampPair.patch


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org