You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/09/08 17:01:57 UTC
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1345: Improvements for SKY66112
apache-mynewt-bot commented on PR #1345:
URL: https://github.com/apache/mynewt-nimble/pull/1345#issuecomment-1240982078
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/controller/src/ble_ll_hci_vs.c
<details>
```diff
@@ -355,7 +355,7 @@
#if MYNEWT_VAL(BLE_LL_FEM_ANTENNA)
static int
ble_ll_hci_vs_set_antenna(uint16_t ocf, const uint8_t *cmdbuf, uint8_t cmdlen,
- uint8_t *rspbuf, uint8_t *rsplen)
+ uint8_t *rspbuf, uint8_t *rsplen)
{
const struct ble_hci_vs_set_antenna_cp *cmd = (const void *) cmdbuf;
```
</details>
#### nimble/drivers/nrf52/src/ble_phy.c
<details>
```diff
@@ -324,8 +322,8 @@
#if MYNEWT_VAL(BLE_LL_FEM_PA) || MYNEWT_VAL(BLE_LL_FEM_LNA)
#define FEM_SINGLE_GPIO \
- (!MYNEWT_VAL(BLE_LL_FEM_PA) || !MYNEWT_VAL(BLE_LL_FEM_LNA) || \
- (MYNEWT_VAL(BLE_LL_FEM_PA_GPIO) == MYNEWT_VAL(BLE_LL_FEM_LNA_GPIO)))
+ (!MYNEWT_VAL(BLE_LL_FEM_PA) || !MYNEWT_VAL(BLE_LL_FEM_LNA) || \
+ (MYNEWT_VAL(BLE_LL_FEM_PA_GPIO) == MYNEWT_VAL(BLE_LL_FEM_LNA_GPIO)))
#if FEM_SINGLE_GPIO
static uint8_t fem_idx;
```
</details>
#### nimble/drivers/nrf5340/src/ble_phy.c
<details>
```diff
@@ -60,7 +60,7 @@
DPPIC_CHEN_CH3_Msk | DPPIC_CHEN_CH4_Msk | DPPIC_CHEN_CH5_Msk)
#define DPPI_CH_MASK_FEM (DPPI_CH_MASK(TIMER0_EVENTS_COMPARE_4) | \
- DPPI_CH_MASK(RADIO_EVENTS_DISABLED))
+ DPPI_CH_MASK(RADIO_EVENTS_DISABLED))
extern uint8_t g_nrf_num_irks;
extern uint32_t g_nrf_irk_list[];
@@ -247,8 +247,8 @@
#if MYNEWT_VAL(BLE_LL_FEM_PA) || MYNEWT_VAL(BLE_LL_FEM_LNA)
#define FEM_SINGLE_GPIO \
- (!MYNEWT_VAL(BLE_LL_FEM_PA) || !MYNEWT_VAL(BLE_LL_FEM_LNA) || \
- (MYNEWT_VAL(BLE_LL_FEM_PA_GPIO) == MYNEWT_VAL(BLE_LL_FEM_LNA_GPIO)))
+ (!MYNEWT_VAL(BLE_LL_FEM_PA) || !MYNEWT_VAL(BLE_LL_FEM_LNA) || \
+ (MYNEWT_VAL(BLE_LL_FEM_PA_GPIO) == MYNEWT_VAL(BLE_LL_FEM_LNA_GPIO)))
#if FEM_SINGLE_GPIO
static uint8_t fem_idx;
@@ -1257,20 +1258,20 @@
NRF_RADIO_NS->INTENCLR = RADIO_INTENCLR_DISABLED_Msk;
switch (g_ble_phy_data.phy_state) {
- case BLE_PHY_STATE_RX:
- ble_phy_fem_disable_lna();
- if (g_ble_phy_data.phy_rx_started) {
- ble_phy_rx_end_isr();
- } else {
- ble_ll_wfr_timer_exp(NULL);
- }
- break;
- case BLE_PHY_STATE_TX:
- ble_phy_fem_disable_pa();
- ble_phy_tx_end_isr();
- break;
- default:
- BLE_LL_ASSERT(0);
+ case BLE_PHY_STATE_RX:
+ ble_phy_fem_disable_lna();
+ if (g_ble_phy_data.phy_rx_started) {
+ ble_phy_rx_end_isr();
+ } else {
+ ble_ll_wfr_timer_exp(NULL);
+ }
+ break;
+ case BLE_PHY_STATE_TX:
+ ble_phy_fem_disable_pa();
+ ble_phy_tx_end_isr();
+ break;
+ default:
+ BLE_LL_ASSERT(0);
}
}
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org