You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2018/05/02 05:19:45 UTC
[GitHub] spark pull request #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVe...
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/21211
[SPARK-24131][PYSPARK][Followup] Add majorMinorVersion API to PySpark for determining Spark versions
## What changes were proposed in this pull request?
More close to Scala API behavior when can't parse input by throwing exception. Add tests.
## How was this patch tested?
Added tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 SPARK-24131-followup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21211.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21211
----
commit e4b886732d5bb844c66116a4751dc9a92173a928
Author: Liang-Chi Hsieh <vi...@...>
Date: 2018-05-02T05:17:22Z
Add tests and throw exception when we can't parse input.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVe...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21211#discussion_r185397366
--- Diff: python/pyspark/util.py ---
@@ -62,24 +62,28 @@ def _get_argspec(f):
return argspec
-def majorMinorVersion(version):
+class VersionUtils(object):
"""
- Get major and minor version numbers for given Spark version string.
-
- >>> version = "2.4.0"
- >>> majorMinorVersion(version)
- (2, 4)
+ Provides utility method to determine Spark versions with given input string.
--- End diff --
```
* Given a Spark version string, return the (major version number, minor version number).
* E.g., for 2.0.1-SNAPSHOT, return (2, 0).
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21211
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21211
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21211
Thanks @HyukjinKwon
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21211
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21211
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90064/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVe...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21211#discussion_r185397554
--- Diff: python/pyspark/tests.py ---
@@ -2303,6 +2303,15 @@ def test_py4j_exception_message(self):
self.assertTrue('NullPointerException' in _exception_message(context.exception))
+ def test_parsing_version_string(self):
+ from pyspark.util import VersionUtils
+
+ (major, minor) = VersionUtils.majorMinorVersion("2.4.0")
--- End diff --
I think we don't need this since it's tested in doctests.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21211
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2793/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21211
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21211
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21211
@jkbradley, have you had a change to take a look? If there's no more comments, will just merge it in few days.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVe...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21211#discussion_r185397426
--- Diff: python/pyspark/util.py ---
@@ -62,24 +62,28 @@ def _get_argspec(f):
return argspec
-def majorMinorVersion(version):
+class VersionUtils(object):
"""
- Get major and minor version numbers for given Spark version string.
-
- >>> version = "2.4.0"
- >>> majorMinorVersion(version)
- (2, 4)
+ Provides utility method to determine Spark versions with given input string.
+ """
+ @staticmethod
+ def majorMinorVersion(version):
+ """
+ Get major and minor version numbers for given Spark version string.
- >>> version = "abc"
- >>> majorMinorVersion(version) is None
- True
+ >>> version = "2.4.0"
+ >>> majorMinorVersion(version)
+ (2, 4)
+ >>> version = "2.3.0-SNAPSHOT"
+ >>> majorMinorVersion(version)
+ (2, 3)
- """
- m = re.search('^(\d+)\.(\d+)(\..*)?$', version)
- if m is None:
- return None
- else:
- return (int(m.group(1)), int(m.group(2)))
+ """
+ m = re.search('^(\d+)\.(\d+)(\..*)?$', version)
+ if m is None:
--- End diff --
I'd do `if m is not None` to match the order with Scala side.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVe...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21211#discussion_r185397488
--- Diff: python/pyspark/util.py ---
@@ -62,24 +62,28 @@ def _get_argspec(f):
return argspec
-def majorMinorVersion(version):
+class VersionUtils(object):
"""
- Get major and minor version numbers for given Spark version string.
-
- >>> version = "2.4.0"
- >>> majorMinorVersion(version)
- (2, 4)
+ Provides utility method to determine Spark versions with given input string.
+ """
+ @staticmethod
+ def majorMinorVersion(version):
+ """
+ Get major and minor version numbers for given Spark version string.
--- End diff --
```
* Given a Spark version string, return the (major version number, minor version number).
* E.g., for 2.0.1-SNAPSHOT, return (2, 0).
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVe...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21211#discussion_r185397304
--- Diff: python/pyspark/util.py ---
@@ -62,24 +62,28 @@ def _get_argspec(f):
return argspec
-def majorMinorVersion(version):
+class VersionUtils(object):
"""
- Get major and minor version numbers for given Spark version string.
-
- >>> version = "2.4.0"
- >>> majorMinorVersion(version)
- (2, 4)
+ Provides utility method to determine Spark versions with given input string.
+ """
+ @staticmethod
+ def majorMinorVersion(version):
+ """
+ Get major and minor version numbers for given Spark version string.
- >>> version = "abc"
- >>> majorMinorVersion(version) is None
- True
+ >>> version = "2.4.0"
+ >>> majorMinorVersion(version)
+ (2, 4)
+ >>> version = "2.3.0-SNAPSHOT"
+ >>> majorMinorVersion(version)
+ (2, 3)
- """
- m = re.search('^(\d+)\.(\d+)(\..*)?$', version)
- if m is None:
- return None
- else:
- return (int(m.group(1)), int(m.group(2)))
+ """
+ m = re.search('^(\d+)\.(\d+)(\..*)?$', version)
+ if m is None:
+ raise ValueError("invalid version string: " + version)
--- End diff --
Shall we match the message with Scala side?
```
throw new IllegalArgumentException(s"Spark tried to parse '$sparkVersion' as a Spark" +
s" version string, but it could not find the major and minor version numbers.")
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21211
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21211
**[Test build #90030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90030/testReport)** for PR 21211 at commit [`e4b8867`](https://github.com/apache/spark/commit/e4b886732d5bb844c66116a4751dc9a92173a928).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21211
**[Test build #90064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90064/testReport)** for PR 21211 at commit [`d2bcfe2`](https://github.com/apache/spark/commit/d2bcfe2a892d627002a4cac678712693986778c2).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVe...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21211#discussion_r185397331
--- Diff: python/pyspark/util.py ---
@@ -62,24 +62,28 @@ def _get_argspec(f):
return argspec
-def majorMinorVersion(version):
+class VersionUtils(object):
"""
- Get major and minor version numbers for given Spark version string.
-
- >>> version = "2.4.0"
- >>> majorMinorVersion(version)
- (2, 4)
+ Provides utility method to determine Spark versions with given input string.
+ """
+ @staticmethod
+ def majorMinorVersion(version):
--- End diff --
`version` -> `sparkVersion`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21211
@HyukjinKwon Thanks! I forgot to change doctests. I will update and address
your comments once I get access of my laptop.
On Wed, May 2, 2018, 1:41 PM Hyukjin Kwon <no...@github.com> wrote:
> *@HyukjinKwon* commented on this pull request.
>
> Seems fine otherwise but let me leave it to @jkbradley
> <https://github.com/jkbradley>.
> ------------------------------
>
> In python/pyspark/util.py
> <https://github.com/apache/spark/pull/21211#discussion_r185397304>:
>
> >
> - """
> - m = re.search('^(\d+)\.(\d+)(\..*)?$', version)
> - if m is None:
> - return None
> - else:
> - return (int(m.group(1)), int(m.group(2)))
> + """
> + m = re.search('^(\d+)\.(\d+)(\..*)?$', version)
> + if m is None:
> + raise ValueError("invalid version string: " + version)
>
> Shall we match the message with Scala side?
>
> throw new IllegalArgumentException(s"Spark tried to parse '$sparkVersion' as a Spark" +
> s" version string, but it could not find the major and minor version numbers.")
>
> ------------------------------
>
> In python/pyspark/util.py
> <https://github.com/apache/spark/pull/21211#discussion_r185397331>:
>
> > """
> - Get major and minor version numbers for given Spark version string.
> -
> - >>> version = "2.4.0"
> - >>> majorMinorVersion(version)
> - (2, 4)
> + Provides utility method to determine Spark versions with given input string.
> + """
> + @staticmethod
> + def majorMinorVersion(version):
>
> version -> sparkVersion.
> ------------------------------
>
> In python/pyspark/util.py
> <https://github.com/apache/spark/pull/21211#discussion_r185397366>:
>
> > """
> - Get major and minor version numbers for given Spark version string.
> -
> - >>> version = "2.4.0"
> - >>> majorMinorVersion(version)
> - (2, 4)
> + Provides utility method to determine Spark versions with given input string.
>
> * Given a Spark version string, return the (major version number, minor version number).
> * E.g., for 2.0.1-SNAPSHOT, return (2, 0).
>
> ------------------------------
>
> In python/pyspark/util.py
> <https://github.com/apache/spark/pull/21211#discussion_r185397426>:
>
> >
> - """
> - m = re.search('^(\d+)\.(\d+)(\..*)?$', version)
> - if m is None:
> - return None
> - else:
> - return (int(m.group(1)), int(m.group(2)))
> + """
> + m = re.search('^(\d+)\.(\d+)(\..*)?$', version)
> + if m is None:
>
> I'd do if m is not None to match the order with Scala side.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/21211#pullrequestreview-116775229>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAEM95EttpNHdza3nQplTx476aMF9i1Jks5tuUcPgaJpZM4Tu3oh>
> .
>
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21211
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21211
**[Test build #90348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90348/testReport)** for PR 21211 at commit [`d2bcfe2`](https://github.com/apache/spark/commit/d2bcfe2a892d627002a4cac678712693986778c2).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21211
Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21211
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2818/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21211
cc @jkbradley @HyukjinKwon
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21211
**[Test build #90064 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90064/testReport)** for PR 21211 at commit [`d2bcfe2`](https://github.com/apache/spark/commit/d2bcfe2a892d627002a4cac678712693986778c2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21211
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90348/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21211
**[Test build #90348 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90348/testReport)** for PR 21211 at commit [`d2bcfe2`](https://github.com/apache/spark/commit/d2bcfe2a892d627002a4cac678712693986778c2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21211
**[Test build #90030 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90030/testReport)** for PR 21211 at commit [`e4b8867`](https://github.com/apache/spark/commit/e4b886732d5bb844c66116a4751dc9a92173a928).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class VersionUtils(object):`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21211
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3021/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21211
@HyukjinKwon Thanks for the comments above. I think I addressed them all.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21211
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21211: [SPARK-24131][PYSPARK][Followup] Add majorMinorVersion A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21211
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90030/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org