You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Norman Maurer (JIRA)" <se...@james.apache.org> on 2008/12/14 16:47:44 UTC
[jira] Created: (JAMES-882) VirtualUserTable-Store is not working
anymore
VirtualUserTable-Store is not working anymore
---------------------------------------------
Key: JAMES-882
URL: https://issues.apache.org/jira/browse/JAMES-882
Project: JAMES Server
Issue Type: Bug
Affects Versions: 3.0, Trunk
Reporter: Norman Maurer
Assignee: Norman Maurer
Fix For: 3.0
Attachments: vut-support.diff
In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658158#action_12658158 ]
Robert Burrell Donkin commented on JAMES-882:
---------------------------------------------
I'm a little confused. Can anyone explain how the follow code set new local recipients?
public abstract class AbstractVirtualUserTableMailet extends GenericMailet {
/*
* (non-Javadoc)
* @see org.apache.mailet.base.GenericMailet#service(org.apache.mailet.Mail)
*/
public void service(Mail mail) throws MessagingException {
Collection recipients = mail.getRecipients();
Collection errors = new Vector();
MimeMessage message = mail.getMessage();
// Set Return-Path and remove all other Return-Path headers from the
// message
// This only works because there is a placeholder inserted by
// MimeMessageWrapper
message
.setHeader(RFC2822Headers.RETURN_PATH,
(mail.getSender() == null ? "<>" : "<"
+ mail.getSender() + ">"));
Collection newRecipients = new LinkedList();
for (Iterator i = recipients.iterator(); i.hasNext();) {
MailAddress recipient = (MailAddress) i.next();
try {
Collection usernames = processMail(mail.getSender(), recipient,
message);
// if the username is null or changed we remove it from the
// remaining recipients
if (usernames == null) {
i.remove();
} else {
i.remove();
// if the username has been changed we add a new recipient
// with the new name.
newRecipients.addAll(usernames);
}
} catch (Exception ex) {
getMailetContext().log("Error while storing mail.", ex);
errors.add(recipient);
}
}
if (newRecipients.size() > 0) {
recipients.addAll(newRecipients);
}
if (!errors.isEmpty()) {
// If there were errors, we redirect the email to the ERROR
// processor.
// In order for this server to meet the requirements of the SMTP
// specification, mails on the ERROR processor must be returned to
// the sender. Note that this email doesn't include any details
// regarding the details of the failure(s).
// In the future we may wish to address this.
getMailetContext().sendMail(mail.getSender(), errors, message,
Mail.ERROR);
}
if (recipients.size() == 0) {
// We always consume this message
mail.setState(Mail.GHOST);
}
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: diff.txt, vut-smoke.patch, vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657914#action_12657914 ]
Robert Burrell Donkin commented on JAMES-882:
---------------------------------------------
Bit confused in the last comment. I can't see how the local delivery is supposed to work either in the old or new mailets.
I would expect the mail mapped to local users to be posted back into the system with new recipiants but AFACT it's not.
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: diff.txt, vut-smoke.patch, vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Resolved: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Norman Maurer resolved JAMES-882.
---------------------------------
Resolution: Fixed
Fix Version/s: Trunk
Its workin again..
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0, Trunk
>
> Attachments: diff.txt, vut-smoke.patch, vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Norman Maurer updated JAMES-882:
--------------------------------
Fix Version/s: (was: Trunk)
3.0-M1
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0, 3.0-M1
>
> Attachments: diff.txt, vut-smoke.patch, vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657106#action_12657106 ]
Norman Maurer commented on JAMES-882:
-------------------------------------
Hi all,
today I tried to complete the fix for it, but it seems I can't get the dependency injection stuff to get work. Maybe some can check the James.xinfo and assembly.xml to see if he can spot an error ?
Thx
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: vut-smoke.patch, vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656404#action_12656404 ]
Robert Burrell Donkin commented on JAMES-882:
---------------------------------------------
I'm happy to see this committed if it works for you. I don't really want to get into a massive design debate ATM.
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656403#action_12656403 ]
Norman Maurer commented on JAMES-882:
-------------------------------------
@Robert: what VUT support you are talking about ( LocalDelivery) ?
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656405#action_12656405 ]
Robert Burrell Donkin commented on JAMES-882:
---------------------------------------------
I've attached the VUT smoke test
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: vut-smoke.patch, vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by Stefano Bagnara <ap...@bago.org>.
Robert Burrell Donkin (JIRA) ha scritto:
> [ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657592#action_12657592 ]
>
> Robert Burrell Donkin commented on JAMES-882:
> ---------------------------------------------
>
> James was failing the smoke tests (basically not booting) since the Phoenix stuff wasn't working. I've patched the mailet to use JSR250 since my Phoenix foo is weak. If anyone finds the time and inclination to reverse this change and get the Phoenix stuff working, fine by me.
Even if I'm not yet sure this is the way to go, it is interesting to see
JSR250 in action. Real changes in svn is much better than theoretical
discussion to evaluate the result and the pros/cons. Thank you.
> BTW sorry for missing the JIRA number on the commit :-/
I updated the comment log, IIRC JIRA will pick up the change sooner or
later :-)
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657592#action_12657592 ]
Robert Burrell Donkin commented on JAMES-882:
---------------------------------------------
James was failing the smoke tests (basically not booting) since the Phoenix stuff wasn't working. I've patched the mailet to use JSR250 since my Phoenix foo is weak. If anyone finds the time and inclination to reverse this change and get the Phoenix stuff working, fine by me.
BTW sorry for missing the JIRA number on the commit :-/
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: vut-smoke.patch, vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659576#action_12659576 ]
Robert Burrell Donkin commented on JAMES-882:
---------------------------------------------
I have this working in a smoke test for the phoenix deployment (but not spring). Note that virtual hosting needs to be switched off, or users need to be fully qualified.
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: diff.txt, vut-smoke.patch, vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659224#action_12659224 ]
Robert Burrell Donkin commented on JAMES-882:
---------------------------------------------
ok - so:
1. mail.getRecipients returns an live collection (which when mutated alters recipients for future processing). the Mail javadocs are not clear so i'll patch them
2. the local variable is logically final
if i undestand correctly, LocalMatcher should check this collection and then pass on to LocalDelivery.
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: diff.txt, vut-smoke.patch, vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657732#action_12657732 ]
Norman Maurer commented on JAMES-882:
-------------------------------------
Hi Robert,
thx for diggin.. Unfortunally I still can't get james to start with VirtualUserTable Mailet configured. I get:
ava.lang.RuntimeException: Initialisation failed
at org.apache.james.phoenix.PhoenixLoader.applicationStarted(PhoenixLoader.java:102)
at org.apache.avalon.phoenix.components.application.ListenerSupport.applicationStarted(ListenerSupport.java:238)
at org.apache.avalon.phoenix.components.application.DefaultApplication.doRunPhase(DefaultApplication.java:506)
at org.apache.avalon.phoenix.components.application.DefaultApplication.runPhase(DefaultApplication.java:409)
at org.apache.avalon.phoenix.components.application.DefaultApplication.start(DefaultApplication.java:180)
at org.apache.avalon.framework.container.ContainerUtil.start(ContainerUtil.java:260)
at org.apache.avalon.phoenix.components.kernel.DefaultKernel.startup(DefaultKernel.java:295)
at org.apache.avalon.phoenix.components.kernel.DefaultKernel.addApplication(DefaultKernel.java:376)
at org.apache.avalon.phoenix.components.deployer.DefaultDeployer.deploy(DefaultDeployer.java:357)
at org.apache.avalon.phoenix.components.embeddor.DefaultEmbeddor.deployFile(DefaultEmbeddor.java:542)
at org.apache.avalon.phoenix.components.embeddor.DefaultEmbeddor.deployFile(DefaultEmbeddor.java:535)
at org.apache.avalon.phoenix.components.embeddor.DefaultEmbeddor.deployFiles(DefaultEmbeddor.java:520)
at org.apache.avalon.phoenix.components.embeddor.DefaultEmbeddor.deployDefaultApplications(DefaultEmbeddor.java:509)
at org.apache.avalon.phoenix.components.embeddor.DefaultEmbeddor.execute(DefaultEmbeddor.java:268)
at org.apache.avalon.phoenix.frontends.CLIMain.run(CLIMain.java:198)
at org.apache.avalon.phoenix.frontends.CLIMain.execute(CLIMain.java:184)
at org.apache.avalon.phoenix.frontends.CLIMain.main(CLIMain.java:145)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.avalon.phoenix.launcher.Main.startup(Main.java:135)
at org.apache.avalon.phoenix.launcher.Main.main(Main.java:84)
Caused by: java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.james.phoenix.PhoenixLoader.applicationStarted(PhoenixLoader.java:97)
... 22 more
Caused by: org.apache.avalon.framework.configuration.ConfigurationException: Unable to init mailet @file:/x1/home/norman/james-server-3.0-SNAPSHOT/apps/james/SAR-INF/config.xml:553:48
at org.apache.james.transport.LinearProcessor.configure(LinearProcessor.java:653)
at org.apache.avalon.framework.container.ContainerUtil.configure(ContainerUtil.java:201)
at org.apache.james.transport.StateAwareProcessorList.initialize(StateAwareProcessorList.java:101)
at org.apache.avalon.framework.container.ContainerUtil.initialize(ContainerUtil.java:244)
at org.apache.james.transport.JamesSpoolManager.initialize(JamesSpoolManager.java:159)
... 27 more
Caused by: org.apache.mailet.MailetException: Not initialised. Please ensure that the mailet container supports either setter or constructor injection.
at org.apache.james.transport.mailets.VirtualUserTable.init(VirtualUserTable.java:91)
at org.apache.mailet.base.GenericMailet.init(GenericMailet.java:162)
at org.apache.james.transport.JamesMailetLoader.getMailet(JamesMailetLoader.java:82)
at org.apache.james.transport.LinearProcessor.configure(LinearProcessor.java:628)
... 31 more
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: vut-smoke.patch, vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659202#action_12659202 ]
Stefano Bagnara commented on JAMES-882:
---------------------------------------
Collection recipients = mail.getRecipients();
you get the internal recipients collection and not a copy (MAILET-5)
and then:
if (newRecipients.size() > 0) {
recipients.addAll(newRecipients);
}
Add the new recipients to the collection.
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: diff.txt, vut-smoke.patch, vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657525#action_12657525 ]
Robert Burrell Donkin commented on JAMES-882:
---------------------------------------------
One of the reasons why I added the JSR250 injection was that I really struggled to persuade Phoenix to work. If this still isn't working and it's ok with people, I can try the JSR250 stuff.
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: vut-smoke.patch, vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Norman Maurer updated JAMES-882:
--------------------------------
Attachment: vut-support.diff
Please review
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by Stefano Bagnara <ap...@bago.org>.
Robert Burrell Donkin (JIRA) ha scritto:
> [ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656402#action_12656402 ]
>
> Robert Burrell Donkin commented on JAMES-882:
> ---------------------------------------------
>
> JDBCVirtualUserTable and XMLVirtualUserTable mailets don't use the VUT API. Should the be deleted?
Why? How do we grant backward compatibility if we delete them?
The VUT API is only an alternative (imho better) way to deal with
aliasing that also give us a way to deal with the same vut from mailets
and from smtp handlers.
Stefano
>> VirtualUserTable-Store is not working anymore
>> ---------------------------------------------
>>
>> Key: JAMES-882
>> URL: https://issues.apache.org/jira/browse/JAMES-882
>> Project: JAMES Server
>> Issue Type: Bug
>> Affects Versions: 3.0, Trunk
>> Reporter: Norman Maurer
>> Assignee: Norman Maurer
>> Fix For: 3.0
>>
>> Attachments: vut-support.diff
>>
>>
>> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656402#action_12656402 ]
Robert Burrell Donkin commented on JAMES-882:
---------------------------------------------
JDBCVirtualUserTable and XMLVirtualUserTable mailets don't use the VUT API. Should the be deleted?
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by Stefano Bagnara <ap...@bago.org>.
Robert Burrell Donkin (JIRA) ha scritto:
> [ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656401#action_12656401 ]
>
> Robert Burrell Donkin commented on JAMES-882:
> ---------------------------------------------
>
> isLocalEmail does not correctly take VUT into account so I think VUT support should be removed from LocalDelivery.
I don't understand this. LocalDelivery has no code, it is NOW a
composition of 2 mailets.
LocalDelivery exists to provide backward compatibility. If you need a
LocalDelivery without the VUT then simply use ToMultiRepository ;-)
That split has been done exactly because we didn't like that
LocalDelivery was dealing hardcoded with the useraliasingforwarding stuff.
If your problems is with *naming* then I agree, we can improve things.
If your problem is that supporting backward compatibility make things
harder, OH YES, you can't understand how much I can agree on this. I
lost MONTHS of my 2006 life in order to try to do something new for
james without breaking compatibility. I already classified that time as
*wasted* time, and I have no problem in having a new james release
dropping the backward compatibility. So if there is a good proposal
about a new design (and I repeat that IMHO this issue will touch Mailet
API) for this stuff then I'll be happy to review. I have no time now to
revamp my old proposals.
Stefano
>> VirtualUserTable-Store is not working anymore
>> ---------------------------------------------
>>
>> Key: JAMES-882
>> URL: https://issues.apache.org/jira/browse/JAMES-882
>> Project: JAMES Server
>> Issue Type: Bug
>> Affects Versions: 3.0, Trunk
>> Reporter: Norman Maurer
>> Assignee: Norman Maurer
>> Fix For: 3.0
>>
>> Attachments: vut-support.diff
>>
>>
>> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656401#action_12656401 ]
Robert Burrell Donkin commented on JAMES-882:
---------------------------------------------
isLocalEmail does not correctly take VUT into account so I think VUT support should be removed from LocalDelivery.
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657899#action_12657899 ]
Robert Burrell Donkin commented on JAMES-882:
---------------------------------------------
That should be fixed now.
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: vut-smoke.patch, vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Burrell Donkin updated JAMES-882:
----------------------------------------
Attachment: vut-smoke.patch
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: vut-smoke.patch, vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-882) VirtualUserTable-Store is not working
anymore
Posted by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Burrell Donkin updated JAMES-882:
----------------------------------------
Attachment: diff.txt
svn diff http://svn.apache.org/repos/asf/james/server/branches/next-minor/src/java/org/apache/james/transport/mailets/AbstractVirtualUserTable.java http://svn.apache.org/repos/asf/james/server/trunk/mailets-function/src/main/java/org/apache/james/transport/mailets/AbstractVirtualUserTable.java
The current doesn't work and seems to be missed code that actually does stuff (like the forwarding).
> VirtualUserTable-Store is not working anymore
> ---------------------------------------------
>
> Key: JAMES-882
> URL: https://issues.apache.org/jira/browse/JAMES-882
> Project: JAMES Server
> Issue Type: Bug
> Affects Versions: 3.0, Trunk
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0
>
> Attachments: diff.txt, vut-smoke.patch, vut-support.diff
>
>
> In current trunk the VirtualUserTable-Store implementation get never called from a mailet to rewrite recipients.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org