You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2019/06/15 16:12:18 UTC
svn commit: r1861408 -
/pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ErrorDialog.java
Author: tilman
Date: Sat Jun 15 16:12:18 2019
New Revision: 1861408
URL: http://svn.apache.org/viewvc?rev=1861408&view=rev
Log:
PDFBOX-4071: SonarQube fix
Modified:
pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ErrorDialog.java
Modified: pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ErrorDialog.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ErrorDialog.java?rev=1861408&r1=1861407&r2=1861408&view=diff
==============================================================================
--- pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ErrorDialog.java (original)
+++ pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ErrorDialog.java Sat Jun 15 16:12:18 2019
@@ -167,7 +167,7 @@ public class ErrorDialog extends JDialog
{
if (details == null)
{
- details = createDetailedMessage(error);
+ details = createDetailedMessage();
StringBuilder buffer = new StringBuilder();
stacktrace.setText(generateStackTrace(error, buffer).toString());
stacktrace.setCaretPosition(0);
@@ -247,14 +247,13 @@ public class ErrorDialog extends JDialog
/**
* Creates a non-editable widget to display the detailed stack trace.
*/
- JScrollPane createDetailedMessage(Throwable t)
+ JScrollPane createDetailedMessage()
{
stacktrace = new JTextPane();
stacktrace.setEditable(false);
- JScrollPane pane = new JScrollPane(stacktrace,
+ return new JScrollPane(stacktrace,
JScrollPane.VERTICAL_SCROLLBAR_AS_NEEDED,
JScrollPane.HORIZONTAL_SCROLLBAR_AS_NEEDED);
- return pane;
}
/**