(lucene) 01/02: Create context per collector in TestAllGroupsCollector.createRandomCollectorManager (#16094)

[ja...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

javanna pushed a commit to branch branch_10x
in repository https://gitbox.apache.org/repos/asf/lucene.git

commit 4c71597e0eccc1df2f753e1548a8221860171142
Author: gaobinlong <gb...@amazon.com>
AuthorDate: Thu May 21 17:10:59 2026 +0800

    Create context per collector in TestAllGroupsCollector.createRandomCollectorManager (#16094)
    
    In TestAllGroupsCollector.createRandomCollectorManager, we create on context and make it be shared across collectors in concurrent search scenario, this is not thread-safe, need to create context for each collector.
    
    Signed-off-by: Binlong Gao <gb...@amazon.com>
    Co-authored-by: Luca Cavanna <ja...@apache.org>
---
 .../org/apache/lucene/search/grouping/TestAllGroupsCollector.java    | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lucene/grouping/src/test/org/apache/lucene/search/grouping/TestAllGroupsCollector.java b/lucene/grouping/src/test/org/apache/lucene/search/grouping/TestAllGroupsCollector.java
index cddc4eed69a..fe1126ad7c2 100644
--- a/lucene/grouping/src/test/org/apache/lucene/search/grouping/TestAllGroupsCollector.java
+++ b/lucene/grouping/src/test/org/apache/lucene/search/grouping/TestAllGroupsCollector.java
@@ -18,7 +18,6 @@ package org.apache.lucene.search.grouping;
 
 import java.util.Collection;
 import java.util.HashMap;
-import java.util.Map;
 import org.apache.lucene.document.Document;
 import org.apache.lucene.document.Field;
 import org.apache.lucene.document.FieldType;
@@ -133,8 +132,8 @@ public class TestAllGroupsCollector extends LuceneTestCase {
       return new AllGroupsCollectorManager<>(() -> new TermGroupSelector(groupField));
     } else {
       ValueSource vs = new BytesRefFieldSource(groupField);
-      Map<Object, Object> context = new HashMap<>();
-      return new AllGroupsCollectorManager<>(() -> new ValueSourceGroupSelector(vs, context));
+      return new AllGroupsCollectorManager<>(
+          () -> new ValueSourceGroupSelector(vs, new HashMap<>()));
     }
   }
 }