You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/25 12:21:10 UTC
[GitHub] [arrow] vivkong opened a new pull request #8047: ARROW-9844: [CI] Add Go build job on s390x
vivkong opened a new pull request #8047:
URL: https://github.com/apache/arrow/pull/8047
As suggested by @kou in https://github.com/apache/arrow/pull/8011, this will add a Travis CI job for Go on s390x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8047: ARROW-9844: [CI] Add Go build job on s390x
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8047:
URL: https://github.com/apache/arrow/pull/8047#issuecomment-681285381
OK.
The ML thread: https://lists.apache.org/thread.html/r3d4ab3ccc8db7a7a68baa727bf9b6911930b61609c0faaed14e2b773%40%3Cdev.arrow.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vivkong commented on pull request #8047: ARROW-9844: [CI] Add Go build job on s390x
Posted by GitBox <gi...@apache.org>.
vivkong commented on pull request #8047:
URL: https://github.com/apache/arrow/pull/8047#issuecomment-681105501
@kou Sorry I'm not familiar with the process, will this PR be merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #8047: ARROW-9844: [CI] Add Go build job on s390x
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8047:
URL: https://github.com/apache/arrow/pull/8047#discussion_r476912928
##########
File path: .travis.yml
##########
@@ -56,6 +56,14 @@ jobs:
UBUNTU: "20.04"
cares_SOURCE: "BUNDLED"
gRPC_SOURCE: "BUNDLED"
+ - name: "Go on s390x"
+ os: linux
+ arch: s390x
+ env:
+ ARCH: s390x
+ ARROW_CI_MODULES: "GO"
+ DOCKER_IMAGE_ID: debian-go
+ GO: "1.12"
Review comment:
Could you remove this to use the default value in `.env`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #8047: ARROW-9844: [CI] Add Go build job on s390x
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #8047:
URL: https://github.com/apache/arrow/pull/8047#issuecomment-681265603
We should probably hold off merging more PRs for big endian architectures until we come to consensus on this on the ML about support in general
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8047: ARROW-9844: [CI] Add Go build job on s390x
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8047:
URL: https://github.com/apache/arrow/pull/8047#issuecomment-679995772
https://issues.apache.org/jira/browse/ARROW-9844
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8047: ARROW-9844: [CI] Add Go build job on s390x
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8047:
URL: https://github.com/apache/arrow/pull/8047#issuecomment-681174260
This PR has been merged into master: https://github.com/apache/arrow/commit/92e01cc5ebe912f0ad1377eae765aa36478db52f
We use our merge tool https://github.com/apache/arrow/blob/master/dev/merge_arrow_pr.py instead of using GitHub's merge UI to update corresponding JIRA issue too. We close PR but the change is merged.
Now, you can use the CI job in https://github.com/apache/arrow/pull/8011 by rebasing on master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vivkong commented on pull request #8047: ARROW-9844: [CI] Add Go build job on s390x
Posted by GitBox <gi...@apache.org>.
vivkong commented on pull request #8047:
URL: https://github.com/apache/arrow/pull/8047#issuecomment-682090334
Right I understand. Thanks @emkornfield and @kou.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #8047: ARROW-9844: [CI] Add Go build job on s390x
Posted by GitBox <gi...@apache.org>.
kou closed pull request #8047:
URL: https://github.com/apache/arrow/pull/8047
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vivkong commented on a change in pull request #8047: ARROW-9844: [CI] Add Go build job on s390x
Posted by GitBox <gi...@apache.org>.
vivkong commented on a change in pull request #8047:
URL: https://github.com/apache/arrow/pull/8047#discussion_r477266332
##########
File path: .travis.yml
##########
@@ -56,6 +56,14 @@ jobs:
UBUNTU: "20.04"
cares_SOURCE: "BUNDLED"
gRPC_SOURCE: "BUNDLED"
+ - name: "Go on s390x"
+ os: linux
+ arch: s390x
+ env:
+ ARCH: s390x
+ ARROW_CI_MODULES: "GO"
+ DOCKER_IMAGE_ID: debian-go
+ GO: "1.12"
Review comment:
Thanks for your feedback. I've removed the line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org