You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/08/06 22:46:14 UTC
[jira] Created: (CASSANDRA-351) fixes for code review of #332
fixes for code review of #332
-----------------------------
Key: CASSANDRA-351
URL: https://issues.apache.org/jira/browse/CASSANDRA-351
Project: Cassandra
Issue Type: Sub-task
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-351) fixes for code review of #332
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740337#action_12740337 ]
Jun Rao commented on CASSANDRA-351:
-----------------------------------
Also, I'd increase the number of columns inserted in TableTest.testGetSliceFromLarge() from 1000 to 4000 since ColumnIndexSizeInKB is only 4.
> fixes for code review of #332
> -----------------------------
>
> Key: CASSANDRA-351
> URL: https://issues.apache.org/jira/browse/CASSANDRA-351
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-351-compact-slicelarge-row-to-ensure-we-are.txt, 0002-inline-excessively-abstracted-reTest-setup.txt, 0003-failing-tests.txt, 0004-fix-for-bsearch-returning-not-found-to-the-right.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-351) fixes for code review of #332
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740886#action_12740886 ]
Hudson commented on CASSANDRA-351:
----------------------------------
Integrated in Cassandra #161 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/161/])
tests + fix for bsearch returning not-found-to-the-right
patch by jbellis; reviewed by Jun Rao for
inline excessively abstracted reTest setup
patch by jbellis; reviewed by Jun Rao for
compact slicelarge row to ensure we are in fact testing with more than the minimum index count
patch by jbellis; reviewed by Jun Rao for
> fixes for code review of #332
> -----------------------------
>
> Key: CASSANDRA-351
> URL: https://issues.apache.org/jira/browse/CASSANDRA-351
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-351-compact-slicelarge-row-to-ensure-we-are.txt, 0002-inline-excessively-abstracted-reTest-setup.txt, 0003-failing-tests.txt, 0004-fix-for-bsearch-returning-not-found-to-the-right.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-351) fixes for code review of #332
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740243#action_12740243 ]
Jonathan Ellis commented on CASSANDRA-351:
------------------------------------------
04
fix for bsearch returning not-found-to-the-right in Name and Slice iterators
03
create failing tests
02
inline excessively abstracted reTest setup (TableTest code cleanup)
01
compact slicelarge row to ensure we are in fact testing with more than the minimum index count
> fixes for code review of #332
> -----------------------------
>
> Key: CASSANDRA-351
> URL: https://issues.apache.org/jira/browse/CASSANDRA-351
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-351-compact-slicelarge-row-to-ensure-we-are.txt, 0002-inline-excessively-abstracted-reTest-setup.txt, 0003-failing-tests.txt, 0004-fix-for-bsearch-returning-not-found-to-the-right.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-351) fixes for code review of #332
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740596#action_12740596 ]
Jun Rao commented on CASSANDRA-351:
-----------------------------------
Just make sure that we do have at least 3 index entries and at least one query is using the middle index entry.
> fixes for code review of #332
> -----------------------------
>
> Key: CASSANDRA-351
> URL: https://issues.apache.org/jira/browse/CASSANDRA-351
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-351-compact-slicelarge-row-to-ensure-we-are.txt, 0002-inline-excessively-abstracted-reTest-setup.txt, 0003-failing-tests.txt, 0004-fix-for-bsearch-returning-not-found-to-the-right.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-351) fixes for code review of #332
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740600#action_12740600 ]
Jonathan Ellis commented on CASSANDRA-351:
------------------------------------------
right. patch 1 goes a little white box on the index and explicitly checks for > 2.
> fixes for code review of #332
> -----------------------------
>
> Key: CASSANDRA-351
> URL: https://issues.apache.org/jira/browse/CASSANDRA-351
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-351-compact-slicelarge-row-to-ensure-we-are.txt, 0002-inline-excessively-abstracted-reTest-setup.txt, 0003-failing-tests.txt, 0004-fix-for-bsearch-returning-not-found-to-the-right.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-351) fixes for code review of #332
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-351:
-------------------------------------
Attachment: 0004-fix-for-bsearch-returning-not-found-to-the-right.txt
0003-failing-tests.txt
0002-inline-excessively-abstracted-reTest-setup.txt
0001-CASSANDRA-351-compact-slicelarge-row-to-ensure-we-are.txt
> fixes for code review of #332
> -----------------------------
>
> Key: CASSANDRA-351
> URL: https://issues.apache.org/jira/browse/CASSANDRA-351
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-351-compact-slicelarge-row-to-ensure-we-are.txt, 0002-inline-excessively-abstracted-reTest-setup.txt, 0003-failing-tests.txt, 0004-fix-for-bsearch-returning-not-found-to-the-right.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-351) fixes for code review of #332
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-351.
--------------------------------------
Resolution: Fixed
committed
> fixes for code review of #332
> -----------------------------
>
> Key: CASSANDRA-351
> URL: https://issues.apache.org/jira/browse/CASSANDRA-351
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-351-compact-slicelarge-row-to-ensure-we-are.txt, 0002-inline-excessively-abstracted-reTest-setup.txt, 0003-failing-tests.txt, 0004-fix-for-bsearch-returning-not-found-to-the-right.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-351) fixes for code review of #332
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740350#action_12740350 ]
Jonathan Ellis commented on CASSANDRA-351:
------------------------------------------
that would generate more indexes but once you go beyond 3 you're not really testing anything new, no?
> fixes for code review of #332
> -----------------------------
>
> Key: CASSANDRA-351
> URL: https://issues.apache.org/jira/browse/CASSANDRA-351
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-351-compact-slicelarge-row-to-ensure-we-are.txt, 0002-inline-excessively-abstracted-reTest-setup.txt, 0003-failing-tests.txt, 0004-fix-for-bsearch-returning-not-found-to-the-right.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-351) fixes for code review of #332
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740261#action_12740261 ]
Jun Rao commented on CASSANDRA-351:
-----------------------------------
The patches look good to me.
> fixes for code review of #332
> -----------------------------
>
> Key: CASSANDRA-351
> URL: https://issues.apache.org/jira/browse/CASSANDRA-351
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-351-compact-slicelarge-row-to-ensure-we-are.txt, 0002-inline-excessively-abstracted-reTest-setup.txt, 0003-failing-tests.txt, 0004-fix-for-bsearch-returning-not-found-to-the-right.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.