You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (JIRA)" <ji...@apache.org> on 2013/08/23 06:21:52 UTC

[jira] [Comment Edited] (HBASE-9247) Cleanup Key/KV/Meta/MetaKey Comparators

    [ https://issues.apache.org/jira/browse/HBASE-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748267#comment-13748267 ] 

Jonathan Hsieh edited comment on HBASE-9247 at 8/23/13 4:21 AM:
----------------------------------------------------------------

Big patch touching lots of files but the take away is ~10% less code in KeyValue, (~2891 loc -> 2559 loc).  

KeyValue is public and so are its old comparators; there is some thoughts about compatibility policy we'll need to consider.
                
      was (Author: jmhsieh):
    Big patch touching lots of files but the take away is ~10% less code in KeyValue, (~2891 loc -> 2559 loc).  

KeyValue is public and so are its old comparators there is some thoughts about compatibility policy we'll need to consider.
                  
> Cleanup Key/KV/Meta/MetaKey Comparators
> ---------------------------------------
>
>                 Key: HBASE-9247
>                 URL: https://issues.apache.org/jira/browse/HBASE-9247
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-9247.patch
>
>
> HBASE-9164 converted KVComparator's KeyCompare#compare guts from one that assumed a contiguous array backing a KV to one that used the Cell interface which doesn't have this assumption.
> There is now duplicate code that should be cleaned up.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira