You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "kdamichie (via GitHub)" <gi...@apache.org> on 2023/02/24 19:56:37 UTC
[GitHub] [trafficcontrol] kdamichie opened a new pull request, #7364: Tpv2 coordinates
kdamichie opened a new pull request, #7364:
URL: https://github.com/apache/trafficcontrol/pull/7364
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
Created TPv2 Parity page Coordinates.
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Portal
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
Test that Coordinates exists and new coordinates can be created with name, latitude, and longitude. Verify Edit and Delete features function as well.
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] kdamichie commented on a diff in pull request #7364: Tpv2 coordinates
Posted by "kdamichie (via GitHub)" <gi...@apache.org>.
kdamichie commented on code in PR #7364:
URL: https://github.com/apache/trafficcontrol/pull/7364#discussion_r1122273010
##########
CHANGELOG.md:
##########
@@ -30,6 +30,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- [#7296](https://github.com/apache/trafficcontrol/pull/7296) *Traffic Portal* New configuration option in `traffic_portal_properties.json` at `deliveryServices.exposeInactive` controls exposing APIv5 DS Active State options in the TP UI.
- [#7332](https://github.com/apache/trafficcontrol/pull/7332) *Traffic Ops* Creates new role needed for TR to watch TO resources.
- [#7322](https://github.com/apache/trafficcontrol/issues/7322) *t3c Adds support for anycast on http routed edges.
+- [#7364](https://github.com/apache/trafficcontrol/issues/7364) *Traffic Portal* TPv2 Created Coordinates Page Parity.
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus merged pull request #7364: Tpv2 coordinates
Posted by "shamrickus (via GitHub)" <gi...@apache.org>.
shamrickus merged PR #7364:
URL: https://github.com/apache/trafficcontrol/pull/7364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] kdamichie commented on a diff in pull request #7364: Tpv2 coordinates
Posted by "kdamichie (via GitHub)" <gi...@apache.org>.
kdamichie commented on code in PR #7364:
URL: https://github.com/apache/trafficcontrol/pull/7364#discussion_r1137393788
##########
experimental/traffic-portal/src/app/core/cache-groups/cache-group-details/cache-group-details.component.html:
##########
@@ -56,11 +56,11 @@
<div class="pair">
<mat-form-field>
<mat-label>Latitude</mat-label>
- <input type="number" matInput min="-90" max="90" step="0.001" name="latitude" [(ngModel)]="cacheGroup.latitude" required/>
+ <input type="number" matInput min="-90" max="90" step="0.0000001" name="latitude" [(ngModel)]="cacheGroup.latitude" required/>
Review Comment:
I agree after looking at how finite that gets. I think reverting it back to its original precision is appropriate though, as that is about 328 feet accurate. First decimal is about 6.2 miles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] kdamichie commented on a diff in pull request #7364: Tpv2 coordinates
Posted by "kdamichie (via GitHub)" <gi...@apache.org>.
kdamichie commented on code in PR #7364:
URL: https://github.com/apache/trafficcontrol/pull/7364#discussion_r1122305315
##########
docs/source/api/v5/deliveryservices_xmlid_xmlid_sslkeys_renew.rst:
##########
@@ -0,0 +1,55 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _to-api-deliveryservices-xmlid-xmlid-sslkeys-renew:
+
+**************************************************
+``deliveryservices/xmlId/{{XMLID}}/sslkeys/renew``
+**************************************************
+
+``POST``
+========
+Uses :abbr:`ACME (Automatic Certificate Management Environment)` protocol to renew SSL keys for a :term:`Delivery Service`.
+
+:Auth. Required: Yes
+:Roles Required: "admin"
+:Permissions Required: ACME:READ, DS-SECURITY-KEY:DELETE, DS-SECURITY-KEY:READ, DS-SECURITY-KEY:CREATE, DS-SECURITY-KEY:UPDATE, DELIVERY-SERVICE:READ, DELIVERY-SERVICE:UPDATE
+:Response Type: Object
+
+Request Structure
+-----------------
+.. table:: Request Path Parameters
+
+ +-------+------------------------------------------------------+
+ | Name | Description |
+ +=======+======================================================+
+ | XMLID | The 'xml_id' of the desired :term:`Delivery Service` |
+ +-------+------------------------------------------------------+
+
+
+Request Structure
+-----------------
+No parameters available
+
+
+Response Structure
+------------------
+.. code-block:: json
+ :caption: Response Example
Review Comment:
rebased again. Changes were from first rebase.
##########
docs/source/api/v4/deliveryservices_xmlid_xmlid_sslkeys_renew.rst:
##########
@@ -0,0 +1,55 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _to-api-v4-deliveryservices-xmlid-xmlid-sslkeys-renew:
+
+**************************************************
+``deliveryservices/xmlId/{{XMLID}}/sslkeys/renew``
+**************************************************
+
+``POST``
+========
+Uses :abbr:`ACME (Automatic Certificate Management Environment)` protocol to renew SSL keys for a :term:`Delivery Service`.
+
+:Auth. Required: Yes
+:Roles Required: "admin"
+:Permissions Required: ACME:READ, DS-SECURITY-KEY:DELETE, DS-SECURITY-KEY:READ, DS-SECURITY-KEY:CREATE, DS-SECURITY-KEY:UPDATE, DELIVERY-SERVICE:READ, DELIVERY-SERVICE:UPDATE
+:Response Type: Object
+
+Request Structure
+-----------------
+.. table:: Request Path Parameters
+
+ +-------+------------------------------------------------------+
+ | Name | Description |
+ +=======+======================================================+
+ | XMLID | The 'xml_id' of the desired :term:`Delivery Service` |
+ +-------+------------------------------------------------------+
+
+
+Request Structure
+-----------------
+No parameters available
+
+
+Response Structure
+------------------
+.. code-block:: json
+ :caption: Response Example
Review Comment:
rebased again. Changes were from first rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7364: Tpv2 coordinates
Posted by "shamrickus (via GitHub)" <gi...@apache.org>.
shamrickus commented on code in PR #7364:
URL: https://github.com/apache/trafficcontrol/pull/7364#discussion_r1120108417
##########
CHANGELOG.md:
##########
@@ -30,6 +30,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- [#7296](https://github.com/apache/trafficcontrol/pull/7296) *Traffic Portal* New configuration option in `traffic_portal_properties.json` at `deliveryServices.exposeInactive` controls exposing APIv5 DS Active State options in the TP UI.
- [#7332](https://github.com/apache/trafficcontrol/pull/7332) *Traffic Ops* Creates new role needed for TR to watch TO resources.
- [#7322](https://github.com/apache/trafficcontrol/issues/7322) *t3c Adds support for anycast on http routed edges.
+- [#7364](https://github.com/apache/trafficcontrol/issues/7364) *Traffic Portal* TPv2 Created Coordinates Page Parity.
Review Comment:
We haven't been adding TPv2 (only) stories to the changelog since it's experimental/not released.
##########
experimental/traffic-portal/nightwatch/globals/globals.ts:
##########
@@ -54,8 +56,10 @@ import {
RequestCacheGroup,
ResponseCacheGroup,
ResponsePhysicalLocation,
- RequestPhysicalLocation
+ RequestPhysicalLocation,
+ ResponseCoordinate,
} from "trafficops-types";
+import {RequestCoordinate} from "trafficops-types/dist/coordinate";
Review Comment:
This should be just `.. from "trafficops-types"`
##########
traffic_ops/traffic_ops_golang/routing/routes.go:
##########
@@ -629,10 +629,10 @@ func Routes(d ServerData) ([]Route, http.Handler, error) {
{Version: api.Version{Major: 4, Minor: 0}, Method: http.MethodGet, Path: `logs/newcount/?$`, Handler: logs.GetNewCount, RequiredPrivLevel: auth.PrivLevelReadOnly, RequiredPermissions: []string{"LOG:READ"}, Authenticated: Authenticated, Middlewares: nil, ID: 44058330123},
//Content invalidation jobs
- {Version: api.Version{Major: 4, Minor: 0}, Method: http.MethodGet, Path: `jobs/?$`, Handler: api.ReadHandler(&invalidationjobs.InvalidationJobV4{}), RequiredPrivLevel: auth.PrivLevelReadOnly, RequiredPermissions: nil, Authenticated: Authenticated, Middlewares: nil, ID: 49667820413},
Review Comment:
Rebasing might remove some of these changes but if it doesn't then this needs to be mentioned in the changelog
##########
docs/source/api/v4/deliveryservices_xmlid_xmlid_sslkeys_renew.rst:
##########
@@ -0,0 +1,55 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _to-api-v4-deliveryservices-xmlid-xmlid-sslkeys-renew:
+
+**************************************************
+``deliveryservices/xmlId/{{XMLID}}/sslkeys/renew``
+**************************************************
+
+``POST``
+========
+Uses :abbr:`ACME (Automatic Certificate Management Environment)` protocol to renew SSL keys for a :term:`Delivery Service`.
+
+:Auth. Required: Yes
+:Roles Required: "admin"
+:Permissions Required: ACME:READ, DS-SECURITY-KEY:DELETE, DS-SECURITY-KEY:READ, DS-SECURITY-KEY:CREATE, DS-SECURITY-KEY:UPDATE, DELIVERY-SERVICE:READ, DELIVERY-SERVICE:UPDATE
+:Response Type: Object
+
+Request Structure
+-----------------
+.. table:: Request Path Parameters
+
+ +-------+------------------------------------------------------+
+ | Name | Description |
+ +=======+======================================================+
+ | XMLID | The 'xml_id' of the desired :term:`Delivery Service` |
+ +-------+------------------------------------------------------+
+
+
+Request Structure
+-----------------
+No parameters available
+
+
+Response Structure
+------------------
+.. code-block:: json
+ :caption: Response Example
Review Comment:
Invalid, I believe it just needs a new line between code-block and caption
##########
docs/source/api/v5/deliveryservices_xmlid_xmlid_sslkeys_renew.rst:
##########
@@ -0,0 +1,55 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _to-api-deliveryservices-xmlid-xmlid-sslkeys-renew:
+
+**************************************************
+``deliveryservices/xmlId/{{XMLID}}/sslkeys/renew``
+**************************************************
+
+``POST``
+========
+Uses :abbr:`ACME (Automatic Certificate Management Environment)` protocol to renew SSL keys for a :term:`Delivery Service`.
+
+:Auth. Required: Yes
+:Roles Required: "admin"
+:Permissions Required: ACME:READ, DS-SECURITY-KEY:DELETE, DS-SECURITY-KEY:READ, DS-SECURITY-KEY:CREATE, DS-SECURITY-KEY:UPDATE, DELIVERY-SERVICE:READ, DELIVERY-SERVICE:UPDATE
+:Response Type: Object
+
+Request Structure
+-----------------
+.. table:: Request Path Parameters
+
+ +-------+------------------------------------------------------+
+ | Name | Description |
+ +=======+======================================================+
+ | XMLID | The 'xml_id' of the desired :term:`Delivery Service` |
+ +-------+------------------------------------------------------+
+
+
+Request Structure
+-----------------
+No parameters available
+
+
+Response Structure
+------------------
+.. code-block:: json
+ :caption: Response Example
Review Comment:
Invalid
##########
experimental/traffic-portal/nightwatch/globals/globals.ts:
##########
@@ -54,8 +56,10 @@ import {
RequestCacheGroup,
ResponseCacheGroup,
ResponsePhysicalLocation,
- RequestPhysicalLocation
+ RequestPhysicalLocation,
+ ResponseCoordinate,
} from "trafficops-types";
+import {RequestCoordinate} from "trafficops-types/dist/coordinate";
Review Comment:
Also should be spaces between `RequestCoordinate` and the curly brackets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7364: Tpv2 coordinates
Posted by "shamrickus (via GitHub)" <gi...@apache.org>.
shamrickus commented on code in PR #7364:
URL: https://github.com/apache/trafficcontrol/pull/7364#discussion_r1138751453
##########
experimental/traffic-portal/src/app/core/cache-groups/coordinates/table/coordinates-table.component.ts:
##########
@@ -0,0 +1,134 @@
+/*
+* Licensed under the Apache License, Version 2.0 (the "License");
+* you may not use this file except in compliance with the License.
+* You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
+import { Component, type OnInit } from "@angular/core";
+import { FormControl } from "@angular/forms";
+import { MatDialog } from "@angular/material/dialog";
+import { ActivatedRoute } from "@angular/router";
+import { BehaviorSubject } from "rxjs";
+import { ResponseCoordinate } from "trafficops-types";
+
+import { CacheGroupService } from "src/app/api";
+import { CurrentUserService } from "src/app/shared/currentUser/current-user.service";
Review Comment:
This path got changed to `src/app/shared/current-user/current-user.service` and is probably why all the TPv2 actions are failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] kdamichie commented on a diff in pull request #7364: Tpv2 coordinates
Posted by "kdamichie (via GitHub)" <gi...@apache.org>.
kdamichie commented on code in PR #7364:
URL: https://github.com/apache/trafficcontrol/pull/7364#discussion_r1122305238
##########
docs/source/api/v4/deliveryservices_xmlid_xmlid_sslkeys_renew.rst:
##########
@@ -0,0 +1,55 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _to-api-v4-deliveryservices-xmlid-xmlid-sslkeys-renew:
+
+**************************************************
+``deliveryservices/xmlId/{{XMLID}}/sslkeys/renew``
+**************************************************
+
+``POST``
+========
+Uses :abbr:`ACME (Automatic Certificate Management Environment)` protocol to renew SSL keys for a :term:`Delivery Service`.
+
+:Auth. Required: Yes
+:Roles Required: "admin"
+:Permissions Required: ACME:READ, DS-SECURITY-KEY:DELETE, DS-SECURITY-KEY:READ, DS-SECURITY-KEY:CREATE, DS-SECURITY-KEY:UPDATE, DELIVERY-SERVICE:READ, DELIVERY-SERVICE:UPDATE
+:Response Type: Object
+
+Request Structure
+-----------------
+.. table:: Request Path Parameters
+
+ +-------+------------------------------------------------------+
+ | Name | Description |
+ +=======+======================================================+
+ | XMLID | The 'xml_id' of the desired :term:`Delivery Service` |
+ +-------+------------------------------------------------------+
+
+
+Request Structure
+-----------------
+No parameters available
+
+
+Response Structure
+------------------
+.. code-block:: json
+ :caption: Response Example
Review Comment:
rebased again. Changes from first rebase.
##########
docs/source/api/v5/deliveryservices_xmlid_xmlid_sslkeys_renew.rst:
##########
@@ -0,0 +1,55 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _to-api-deliveryservices-xmlid-xmlid-sslkeys-renew:
+
+**************************************************
+``deliveryservices/xmlId/{{XMLID}}/sslkeys/renew``
+**************************************************
+
+``POST``
+========
+Uses :abbr:`ACME (Automatic Certificate Management Environment)` protocol to renew SSL keys for a :term:`Delivery Service`.
+
+:Auth. Required: Yes
+:Roles Required: "admin"
+:Permissions Required: ACME:READ, DS-SECURITY-KEY:DELETE, DS-SECURITY-KEY:READ, DS-SECURITY-KEY:CREATE, DS-SECURITY-KEY:UPDATE, DELIVERY-SERVICE:READ, DELIVERY-SERVICE:UPDATE
+:Response Type: Object
+
+Request Structure
+-----------------
+.. table:: Request Path Parameters
+
+ +-------+------------------------------------------------------+
+ | Name | Description |
+ +=======+======================================================+
+ | XMLID | The 'xml_id' of the desired :term:`Delivery Service` |
+ +-------+------------------------------------------------------+
+
+
+Request Structure
+-----------------
+No parameters available
+
+
+Response Structure
+------------------
+.. code-block:: json
+ :caption: Response Example
Review Comment:
rebased again. Changes from first rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] kdamichie commented on a diff in pull request #7364: Tpv2 coordinates
Posted by "kdamichie (via GitHub)" <gi...@apache.org>.
kdamichie commented on code in PR #7364:
URL: https://github.com/apache/trafficcontrol/pull/7364#discussion_r1122270966
##########
experimental/traffic-portal/nightwatch/globals/globals.ts:
##########
@@ -54,8 +56,10 @@ import {
RequestCacheGroup,
ResponseCacheGroup,
ResponsePhysicalLocation,
- RequestPhysicalLocation
+ RequestPhysicalLocation,
+ ResponseCoordinate,
} from "trafficops-types";
+import {RequestCoordinate} from "trafficops-types/dist/coordinate";
Review Comment:
Moved it to above import block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] kdamichie commented on a diff in pull request #7364: Tpv2 coordinates
Posted by "kdamichie (via GitHub)" <gi...@apache.org>.
kdamichie commented on code in PR #7364:
URL: https://github.com/apache/trafficcontrol/pull/7364#discussion_r1122304933
##########
traffic_ops/traffic_ops_golang/routing/routes.go:
##########
@@ -629,10 +629,10 @@ func Routes(d ServerData) ([]Route, http.Handler, error) {
{Version: api.Version{Major: 4, Minor: 0}, Method: http.MethodGet, Path: `logs/newcount/?$`, Handler: logs.GetNewCount, RequiredPrivLevel: auth.PrivLevelReadOnly, RequiredPermissions: []string{"LOG:READ"}, Authenticated: Authenticated, Middlewares: nil, ID: 44058330123},
//Content invalidation jobs
- {Version: api.Version{Major: 4, Minor: 0}, Method: http.MethodGet, Path: `jobs/?$`, Handler: api.ReadHandler(&invalidationjobs.InvalidationJobV4{}), RequiredPrivLevel: auth.PrivLevelReadOnly, RequiredPermissions: nil, Authenticated: Authenticated, Middlewares: nil, ID: 49667820413},
Review Comment:
rebased again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7364: Tpv2 coordinates
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7364:
URL: https://github.com/apache/trafficcontrol/pull/7364#issuecomment-1444369538
# [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7364](https://codecov.io/gh/apache/trafficcontrol/pull/7364?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1d7742) into [master](https://codecov.io/gh/apache/trafficcontrol/commit/5335f8098c27d07be4aba924b7e4503c258f3e2a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5335f80) will **increase** coverage by `18.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #7364 +/- ##
=============================================
+ Coverage 25.06% 43.07% +18.00%
Complexity 98 98
=============================================
Files 593 285 -308
Lines 73646 21292 -52354
Branches 90 90
=============================================
- Hits 18460 9171 -9289
+ Misses 53435 11253 -42182
+ Partials 1751 868 -883
```
| Flag | Coverage Δ | |
|---|---|---|
| golib_unit | `53.16% <ø> (ø)` | |
| grove_unit | `4.60% <ø> (ø)` | |
| t3c_unit | `?` | |
| traffic_monitor_unit | `?` | |
| traffic_ops_unit | `?` | |
| traffic_stats_unit | `10.41% <ø> (ø)` | |
| unit_tests | `38.02% <ø> (+15.42%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/trafficcontrol/pull/7364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [traffic\_ops/traffic\_ops\_golang/routing/routes.go](https://codecov.io/gh/apache/trafficcontrol/pull/7364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3JvdXRpbmcvcm91dGVzLmdv) | | |
| [traffic\_monitor/datareq/eventlog.go](https://codecov.io/gh/apache/trafficcontrol/pull/7364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19tb25pdG9yL2RhdGFyZXEvZXZlbnRsb2cuZ28=) | | |
| [...ffic\_ops/traffic\_ops\_golang/auth/password\_check.go](https://codecov.io/gh/apache/trafficcontrol/pull/7364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL2F1dGgvcGFzc3dvcmRfY2hlY2suZ28=) | | |
| [...raffic\_ops/traffic\_ops\_golang/crstats/dsrouting.go](https://codecov.io/gh/apache/trafficcontrol/pull/7364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL2Nyc3RhdHMvZHNyb3V0aW5nLmdv) | | |
| [...affic\_monitor/tools/testcaches/fakesrvrdata/ths.go](https://codecov.io/gh/apache/trafficcontrol/pull/7364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19tb25pdG9yL3Rvb2xzL3Rlc3RjYWNoZXMvZmFrZXNydnJkYXRhL3Rocy5nbw==) | | |
| [traffic\_ops/traffic\_ops\_golang/util/ims/ims.go](https://codecov.io/gh/apache/trafficcontrol/pull/7364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3V0aWwvaW1zL2ltcy5nbw==) | | |
| [...raffic\_ops/traffic\_ops\_golang/crconfig/crconfig.go](https://codecov.io/gh/apache/trafficcontrol/pull/7364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL2NyY29uZmlnL2NyY29uZmlnLmdv) | | |
| [traffic\_monitor/towrap/towrap.go](https://codecov.io/gh/apache/trafficcontrol/pull/7364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19tb25pdG9yL3Rvd3JhcC90b3dyYXAuZ28=) | | |
| [traffic\_ops/traffic\_ops\_golang/login/register.go](https://codecov.io/gh/apache/trafficcontrol/pull/7364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL2xvZ2luL3JlZ2lzdGVyLmdv) | | |
| [traffic\_monitor/manager/opsconfig.go](https://codecov.io/gh/apache/trafficcontrol/pull/7364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19tb25pdG9yL21hbmFnZXIvb3BzY29uZmlnLmdv) | | |
| ... and [299 more](https://codecov.io/gh/apache/trafficcontrol/pull/7364?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7364: Tpv2 coordinates
Posted by "shamrickus (via GitHub)" <gi...@apache.org>.
shamrickus commented on code in PR #7364:
URL: https://github.com/apache/trafficcontrol/pull/7364#discussion_r1124683940
##########
experimental/traffic-portal/src/app/core/cache-groups/coordinates/detail/coordinate-detail.component.html:
##########
@@ -0,0 +1,44 @@
+<!--
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+
+<mat-card>
+ <tp-loading *ngIf="!coordinate"></tp-loading>
+ <form ngNativeValidate (ngSubmit)="submit($event)" *ngIf="coordinate">
+ <mat-card-content>
+ <mat-form-field>
+ <mat-label>Name</mat-label>
+ <input matInput type="text" name="name" required [(ngModel)]="coordinate.name" />
+ </mat-form-field>
+ <mat-form-field>
+ <mat-label>Latitude</mat-label>
+ <input type="number" matInput min="-90" max="90" step="0.0000001" name="latitude" [(ngModel)]="coordinate.latitude" required/>
Review Comment:
Same
##########
experimental/traffic-portal/src/app/core/cache-groups/cache-group-details/cache-group-details.component.html:
##########
@@ -56,11 +56,11 @@
<div class="pair">
<mat-form-field>
<mat-label>Latitude</mat-label>
- <input type="number" matInput min="-90" max="90" step="0.001" name="latitude" [(ngModel)]="cacheGroup.latitude" required/>
+ <input type="number" matInput min="-90" max="90" step="0.0000001" name="latitude" [(ngModel)]="cacheGroup.latitude" required/>
</mat-form-field>
<mat-form-field>
<mat-label>Longitude</mat-label>
- <input type="number" matInput min="-180" max="180" step="0.001" name="longitude" [(ngModel)]="cacheGroup.longitude" required/>
+ <input type="number" matInput min="-180" max="180" step="0.0000001" name="longitude" [(ngModel)]="cacheGroup.longitude" required/>
Review Comment:
Same as above
##########
experimental/traffic-portal/src/app/core/cache-groups/cache-group-details/cache-group-details.component.html:
##########
@@ -56,11 +56,11 @@
<div class="pair">
<mat-form-field>
<mat-label>Latitude</mat-label>
- <input type="number" matInput min="-90" max="90" step="0.001" name="latitude" [(ngModel)]="cacheGroup.latitude" required/>
+ <input type="number" matInput min="-90" max="90" step="0.0000001" name="latitude" [(ngModel)]="cacheGroup.latitude" required/>
Review Comment:
I think the step should have much higher of a step. According to [this](https://gis.stackexchange.com/questions/8650/measuring-accuracy-of-latitude-and-longitude/8674#8674) (You can just skip to the list at the bottom of the answer), the first decimal seems like a much better step. TPv1 uses integer steps but I think that's not enough precision.
##########
experimental/traffic-portal/src/app/core/cache-groups/coordinates/detail/coordinate-detail.component.html:
##########
@@ -0,0 +1,44 @@
+<!--
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+
+<mat-card>
+ <tp-loading *ngIf="!coordinate"></tp-loading>
+ <form ngNativeValidate (ngSubmit)="submit($event)" *ngIf="coordinate">
+ <mat-card-content>
+ <mat-form-field>
+ <mat-label>Name</mat-label>
+ <input matInput type="text" name="name" required [(ngModel)]="coordinate.name" />
+ </mat-form-field>
+ <mat-form-field>
+ <mat-label>Latitude</mat-label>
+ <input type="number" matInput min="-90" max="90" step="0.0000001" name="latitude" [(ngModel)]="coordinate.latitude" required/>
+ </mat-form-field>
+ <mat-form-field>
+ <mat-label>Longitude</mat-label>
+ <input type="number" matInput min="-180" max="180" step="0.0000001" name="longitude" [(ngModel)]="coordinate.longitude" required/>
Review Comment:
Same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org