You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/03 09:56:21 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #22625: Remove empty rule configuration after drop rule.
RaigorJiang opened a new pull request, #22625:
URL: https://github.com/apache/shardingsphere/pull/22625
Remove empty rule configuration after drop rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22625: Remove empty rule configuration after drop rule.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22625:
URL: https://github.com/apache/shardingsphere/pull/22625#issuecomment-1336130371
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22625?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22625](https://codecov.io/gh/apache/shardingsphere/pull/22625?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8040aa3) into [master](https://codecov.io/gh/apache/shardingsphere/commit/53ad7838eeae4ef62d6d2d35e6e8c05852673811?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53ad783) will **decrease** coverage by `0.69%`.
> The diff coverage is `10.00%`.
```diff
@@ Coverage Diff @@
## master #22625 +/- ##
============================================
- Coverage 50.42% 49.73% -0.70%
+ Complexity 2447 2445 -2
============================================
Files 4111 4114 +3
Lines 57589 57601 +12
Branches 9834 9842 +8
============================================
- Hits 29041 28645 -396
- Misses 26049 26495 +446
+ Partials 2499 2461 -38
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...update/DropBroadcastTableRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0Ryb3BCcm9hZGNhc3RUYWJsZVJ1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `72.72% <0.00%> (-8.23%)` | :arrow_down: |
| [...er/update/DropDefaultStrategyStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0Ryb3BEZWZhdWx0U3RyYXRlZ3lTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `70.00% <0.00%> (-5.87%)` | :arrow_down: |
| [.../update/DropShardingTableRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0Ryb3BTaGFyZGluZ1RhYmxlUnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `75.38% <0.00%> (-2.75%)` | :arrow_down: |
| [.../test/sql/parser/external/ExternalSQLParserIT.java](https://codecov.io/gh/apache/shardingsphere/pull/22625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9leHRlcm5hbC9FeHRlcm5hbFNRTFBhcnNlcklULmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...arser/external/ExternalSQLParserTestParameter.java](https://codecov.io/gh/apache/shardingsphere/pull/22625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9leHRlcm5hbC9FeHRlcm5hbFNRTFBhcnNlclRlc3RQYXJhbWV0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...l/loader/ExternalSQLParserTestParameterLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/22625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9leHRlcm5hbC9sb2FkZXIvRXh0ZXJuYWxTUUxQYXJzZXJUZXN0UGFyYW1ldGVyTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...strategy/impl/GitHubTestParameterLoadStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/22625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9leHRlcm5hbC9sb2FkZXIvc3RyYXRlZ3kvaW1wbC9HaXRIdWJUZXN0UGFyYW1ldGVyTG9hZFN0cmF0ZWd5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ategy/impl/LocalFileTestParameterLoadStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/22625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9leHRlcm5hbC9sb2FkZXIvc3RyYXRlZ3kvaW1wbC9Mb2NhbEZpbGVUZXN0UGFyYW1ldGVyTG9hZFN0cmF0ZWd5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ate/DropDatabaseDiscoveryRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9Ecm9wRGF0YWJhc2VEaXNjb3ZlcnlSdWxlU3RhdGVtZW50VXBkYXRlci5qYXZh) | `87.50% <100.00%> (ø)` | |
| [...handler/update/DropShadowRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22625/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvRHJvcFNoYWRvd1J1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `77.77% <100.00%> (ø)` | |
| ... and [60 more](https://codecov.io/gh/apache/shardingsphere/pull/22625/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #22625: Remove empty rule configuration after drop rule.
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #22625:
URL: https://github.com/apache/shardingsphere/pull/22625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org