[GitHub] [beam] Abacn commented on a diff in pull request #25209: Attempt fix GCPIO_Direct tests timeout

["Abacn (via GitHub)" <gi...@apache.org>]

Abacn commented on code in PR #25209:
URL: https://github.com/apache/beam/pull/25209#discussion_r1089781245


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteGroupedRecordsToFiles.java:
##########
@@ -58,11 +57,11 @@ public void processElement(
       for (ElementT tableRow : element.getValue()) {
         if (writer.getByteSize() > maxFileSize) {
           writer.close();
-          writer = rowWriterFactory.createRowWriter(tempFilePrefix, element.getKey());

Review Comment:
   this bug is captured after the modified writeDynamics test. the writer should be created after the `writer.getResult()` call. Otherwise causing `java.lang.IllegalStateException: Not yet closed`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org