You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/09 13:11:20 UTC

[GitHub] [camel-quarkus] ppalaga opened a new pull request #1767: Document cq:create -Dcq.nativeSupported=false for creating JVM-only e…

ppalaga opened a new pull request #1767:
URL: https://github.com/apache/camel-quarkus/pull/1767


   …xtensions 
   
   Fix #1662


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1767: Document cq:create -Dcq.nativeSupported=false for creating JVM-only e…

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1767:
URL: https://github.com/apache/camel-quarkus/pull/1767#discussion_r485622635



##########
File path: docs/modules/ROOT/pages/contributor-guide/create-jvm-only-extension.adoc
##########
@@ -0,0 +1,38 @@
+[[create-jvm-only-extension]]
+= Create a JVM-only extension
+
+== Why JVM-only extensions
+
+Quarkus applications can be built and run in two modes: JVM and native. While native mode is clearly superior when it
+comes to application start time, memory consumption and size on disk, the JVM mode may still be a valid option. Here is
+why:
+
+First, Quarkus works really well on stock JVMs, such as OpenJDK. While the memory consumption and start times are not
+as good as in native mode, they are still very good when
+https://quarkus.io/blog/runtime-performance/#application-start-time[compared] to traditional JVM stacks.
+
+Second, JVM mode beats native mode in https://quarkus.io/blog/runtime-performance/#throughput-reqsec[peak throughput]
+and https://quarkus.io/blog/runtime-performance/#response-times-ms[response latency]. You should prefer JVM mode if
+these metrics matter to you.
+
+And third, creating a Quarkus extension that works well both in JVM and native mode requires some time and
+xref:contributor-guide/create-new-extension.adoc[expertise]. In case some extension is needed quickly and the native
+support is dispensable, relying on JVM-only extensions may make a lot of sense.
+
+== How to create a JVM-only extension
+
+The steps are the same as when xref:contributor-guide/create-new-extension.adoc[creating a native extension], except
+for the following:
+
+* Add `-Dcq.nativeSupported=false` to `cq:create` mojo invocation:

Review comment:
       Oh geez, have forgotten to paste it there?!?! Good catch, man!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1767: Document cq:create -Dcq.nativeSupported=false for creating JVM-only e…

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1767:
URL: https://github.com/apache/camel-quarkus/pull/1767#discussion_r485600455



##########
File path: docs/modules/ROOT/pages/contributor-guide/create-jvm-only-extension.adoc
##########
@@ -0,0 +1,38 @@
+[[create-jvm-only-extension]]
+= Create a JVM-only extension
+
+== Why JVM-only extensions
+
+Quarkus applications can be built and run in two modes: JVM and native. While native mode is clearly superior when it
+comes to application start time, memory consumption and size on disk, the JVM mode may still be a valid option. Here is
+why:
+
+First, Quarkus works really well on stock JVMs, such as OpenJDK. While the memory consumption and start times are not
+as good as in native mode, they are still very good when
+https://quarkus.io/blog/runtime-performance/#application-start-time[compared] to traditional JVM stacks.
+
+Second, JVM mode beats native mode in https://quarkus.io/blog/runtime-performance/#throughput-reqsec[peak throughput]
+and https://quarkus.io/blog/runtime-performance/#response-times-ms[response latency]. You should prefer JVM mode if
+these metrics matter to you.
+
+And third, creating a Quarkus extension that works well both in JVM and native mode requires some time and
+xref:contributor-guide/create-new-extension.adoc[expertise]. In case some extension is needed quickly and the native
+support is dispensable, relying on JVM-only extensions may make a lot of sense.
+
+== How to create a JVM-only extension
+
+The steps are the same as when xref:contributor-guide/create-new-extension.adoc[creating a native extension], except
+for the following:
+
+* Add `-Dcq.nativeSupported=false` to `cq:create` mojo invocation:

Review comment:
       Wouldn't it be better to have this in the source example below so folks can just copy / paste?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga merged pull request #1767: Document cq:create -Dcq.nativeSupported=false for creating JVM-only e…

Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #1767:
URL: https://github.com/apache/camel-quarkus/pull/1767


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org