You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/31 16:36:51 UTC

[GitHub] anirudh2290 commented on a change in pull request #12402: fixed flaky test issue for test_operator_gpu.test_depthwise_convolution

anirudh2290 commented on a change in pull request #12402: fixed flaky test issue for test_operator_gpu.test_depthwise_convolution
URL: https://github.com/apache/incubator-mxnet/pull/12402#discussion_r214410287
 
 

 ##########
 File path: tests/python/unittest/test_operator.py
 ##########
 @@ -1659,7 +1658,7 @@ def test_depthwise_convolution():
                             exe2.backward(exe2.outputs[0])
 
 Review comment:
   can we check whether a downcast is happening when we do `arr2[:] = arr1` from float64 to float32. If yes lets fix that check if the test is still flaky.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services