You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/11/28 22:49:45 UTC
[GitHub] [superset] hughhhh opened a new pull request #17568: feat: Improved SQL Lab Grid rendering
hughhhh opened a new pull request #17568:
URL: https://github.com/apache/superset/pull/17568
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #17568: feat: Improved SQL Lab Grid rendering
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #17568:
URL: https://github.com/apache/superset/pull/17568#discussion_r758245648
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -424,24 +424,21 @@ export default class FilterableTable extends PureComponent<
rowIndex: number;
style: React.CSSProperties;
}) {
+ // if (rowIndex === 0) {
+ // return (
+ // <div key={key} style={style}>
+ // header
+ // </div>
+ // );
+ // }
+
Review comment:
```suggestion
```
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -475,46 +467,25 @@ export default class FilterableTable extends PureComponent<
const getColumnWidth = ({ index }: { index: number }) =>
this.widthsForColumnsByKey[orderedColumnKeys[index]];
+ const { innerWidth: width, innerHeight } = window;
+ console.log('width', width);
+ console.log('length', innerHeight);
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh closed pull request #17568: feat: Improved SQL Lab Grid rendering
Posted by GitBox <gi...@apache.org>.
hughhhh closed pull request #17568:
URL: https://github.com/apache/superset/pull/17568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #17568: feat: Improved SQL Lab Grid rendering
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #17568:
URL: https://github.com/apache/superset/pull/17568#discussion_r758245648
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -424,24 +424,21 @@ export default class FilterableTable extends PureComponent<
rowIndex: number;
style: React.CSSProperties;
}) {
+ // if (rowIndex === 0) {
+ // return (
+ // <div key={key} style={style}>
+ // header
+ // </div>
+ // );
+ // }
+
Review comment:
```suggestion
// if (rowIndex === 0) {
// return (
// <div key={key} style={style}>
// header
// </div>
// );
// }
```
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -475,46 +467,25 @@ export default class FilterableTable extends PureComponent<
const getColumnWidth = ({ index }: { index: number }) =>
this.widthsForColumnsByKey[orderedColumnKeys[index]];
+ const { innerWidth: width, innerHeight } = window;
+ console.log('width', width);
+ console.log('length', innerHeight);
Review comment:
```suggestion
console.log('width', width);
console.log('length', innerHeight);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org