[GitHub] [hbase] wchevreuil commented on a change in pull request #2943: HBASE-25562 ReplicationSourceWALReader log and handle exception immediately without retrying

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #2943:
URL: https://github.com/apache/hbase/pull/2943#discussion_r572766045



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
##########
@@ -148,12 +148,10 @@ public void run() {
           }
         }
       } catch (IOException e) { // stream related
+        LOG.error("Failed to read stream of replication entries", e);

Review comment:
       We already log about the EOF issue inside _handleEofException_, so maybe worth keep this one as debug to avoid flooding the log while we keep retrying?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org