[GitHub] [lucene] rmuir commented on a diff in pull request #829: LUCENE-10525 Improve WindowsFS emulation to catch invalid file names

[GitBox <gi...@apache.org>]

rmuir commented on code in PR #829:
URL: https://github.com/apache/lucene/pull/829#discussion_r855707426


##########
lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/FilterPath.java:
##########
@@ -270,7 +270,7 @@ public static Path unwrap(Path path) {
     return Unwrappable.unwrapAll(path);
   }
 
-  private final Path wrap(Path other) {
+  final Path wrap(Path other) {

Review Comment:
   maybe we can make it protected rather than package private. it is just a helper, so its harmless as long as it remains `final`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org