You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/01/27 09:12:30 UTC
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8280: Add more battery operation
xiaoxiang781216 opened a new pull request, #8280:
URL: https://github.com/apache/nuttx/pull/8280
## Summary
- Charge: Add shipmode into battery_ioctl.h
- Charge: Add cut-off current interface
## Impact
New operation
## Testing
Xiaomi Watch S1 Pro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8280: Add more battery operation
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #8280:
URL: https://github.com/apache/nuttx/pull/8280#issuecomment-1406245194
Maybe it worth of a single commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8280: Add more battery operation
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8280:
URL: https://github.com/apache/nuttx/pull/8280#issuecomment-1406660876
> Maybe it worth of a single commit?
The requirement come one by one:(.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #8280: Add more battery operation
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #8280:
URL: https://github.com/apache/nuttx/pull/8280#discussion_r1090905217
##########
include/nuttx/power/battery_ioctl.h:
##########
@@ -143,6 +143,7 @@ enum batio_operate_e
BATIO_OPRTN_SYSON,
BATIO_OPRTN_RESET,
BATIO_OPRTN_WDOG,
+ BATIO_OPRTN_SHIPMODE,
Review Comment:
I was going to suggest a generic name like _STANDBY, but I agree _SHIPMODE has a sense of purpose. In the automotive industry we use it too when shipping a car from a country to another or even inside big countries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8280: Add more battery operation
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8280:
URL: https://github.com/apache/nuttx/pull/8280#discussion_r1090940485
##########
include/nuttx/power/battery_ioctl.h:
##########
@@ -143,6 +143,7 @@ enum batio_operate_e
BATIO_OPRTN_SYSON,
BATIO_OPRTN_RESET,
BATIO_OPRTN_WDOG,
+ BATIO_OPRTN_SHIPMODE,
Review Comment:
The standby is too general and may give the programmer the expression that the charger will switch between standby and normal frequently. But the ship mode is set on factory line, exit when the customer activates the device at first time, and then never come back to the ship mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8280: Add more battery operation
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8280:
URL: https://github.com/apache/nuttx/pull/8280#discussion_r1090931717
##########
include/nuttx/power/battery_ioctl.h:
##########
@@ -144,6 +144,7 @@ enum batio_operate_e
BATIO_OPRTN_RESET,
BATIO_OPRTN_WDOG,
BATIO_OPRTN_SHIPMODE,
+ BATIO_OPRTN_CUTOFF_CURRENT,
Review Comment:
BATIO_OPRTN_CUTOFF_CURRENT is used to set the end condition: the charger stop when the charging current is smaller than the specific value by this operation. It's different from BATIO_OPRTN_SYSOFF and BATIO_OPRTN_HIZ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis merged pull request #8280: Add more battery operation
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #8280:
URL: https://github.com/apache/nuttx/pull/8280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #8280: Add more battery operation
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #8280:
URL: https://github.com/apache/nuttx/pull/8280#discussion_r1090905217
##########
include/nuttx/power/battery_ioctl.h:
##########
@@ -143,6 +143,7 @@ enum batio_operate_e
BATIO_OPRTN_SYSON,
BATIO_OPRTN_RESET,
BATIO_OPRTN_WDOG,
+ BATIO_OPRTN_SHIPMODE,
Review Comment:
I was going to suggest a generic name like _STANDBY, but I agree _SHIPMODE is has a sense of purpose. In the automotive industry we use it too when shipping a car from a country to another or even inside big countries
##########
include/nuttx/power/battery_ioctl.h:
##########
@@ -144,6 +144,7 @@ enum batio_operate_e
BATIO_OPRTN_RESET,
BATIO_OPRTN_WDOG,
BATIO_OPRTN_SHIPMODE,
+ BATIO_OPRTN_CUTOFF_CURRENT,
Review Comment:
Isn't BATIO_OPRTN_CUTOFF_CURRENT equivalent to BATIO_OPRTN_SYSOFF or even BATIO_OPRTN_HIZ ? What is the purpose in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org