Re: [PR] WIP: AMQ-9552: Add metric lastMessageTimestamp to StatisticsBroker based o… [activemq]

["ggkochanski (via GitHub)" <gi...@apache.org>]

ggkochanski commented on code in PR #1285:
URL: https://github.com/apache/activemq/pull/1285#discussion_r1770280543


##########
activemq-broker/src/main/java/org/apache/activemq/plugin/StatisticsBroker.java:
##########
@@ -160,6 +160,11 @@ else if (dest instanceof Topic) {
                                 tempFirstMessage.clear();
                             }
                         }
+                        if ( stats.getEnqueues().hasUpdated() ) {
+                            // NOTICE: Client-side, you may get the broker "now" Timestamp by msg.getJMSTimestamp()
+                            // This allows for calculating inactivity.
+                            statsMessage.setLong("lastMessageTimestamp", stats.getEnqueues().getLastSampleTime());

Review Comment:
   @mattrpav I can see your change is merged, so I'm refreshing the pull request.
   
   I understand the name unification motivation. Should I change name **lastMessageTimestamp** into **lastEnqueTimestamp** here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact