You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Daniel Becker (Jira)" <ji...@apache.org> on 2023/04/25 14:58:00 UTC

[jira] [Created] (IMPALA-12098) Remove duplicate implementations in read-write-util.h and bit-stream-utils.h

Daniel Becker created IMPALA-12098:
--------------------------------------

             Summary: Remove duplicate implementations in read-write-util.h and bit-stream-utils.h
                 Key: IMPALA-12098
                 URL: https://issues.apache.org/jira/browse/IMPALA-12098
             Project: IMPALA
          Issue Type: Improvement
            Reporter: Daniel Becker
            Assignee: Daniel Becker


Some functions do essentially the same thing in read-write-util.h and bit-stream-utils.h. We could either remove some of them or implement some of them in terms of the other.
Examples:
ReadWriteUtil::PutZLong, ReadWriteUtil::PutZInt - BitWriter::PutZigZagInteger
ReadWriteUtil::ReadZLong, ReadWriteUtil::ReadZInt - BatchedBitReader::GetZigZagInteger

Not that ReadWriteUtil::PutVLong and ReadWriteUtil::PutVInt do NOT correspond to BitWriter::PutUleb128.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org