You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/04/06 01:14:01 UTC
[GitHub] flink pull request #3680: [FLINK-6268] [core] Object reuse for Either type
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3680
[FLINK-6268] [core] Object reuse for Either type
Implement object reuse for Flink's Either type by storing a reference to Right in Left and Left in Right. These references are private and remain null until set by EitherSerializer when copying or deserializing with object reuse.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 6268_object_reuse_for_either_type
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3680.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3680
----
commit aa8df2f75a2cfc225db0770f1b56aa36c7bed361
Author: Greg Hogan <co...@greghogan.com>
Date: 2017-04-05T14:12:04Z
[FLINK-6268] [core] Object reuse for Either type
Implement object reuse for Flink's Either type by storing a reference to
Right in Left and Left in Right. These references are private and remain
null until set by EitherSerializer when copying or deserializing with
object reuse.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3680: [FLINK-6268] [core] Object reuse for Either type
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3680
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3680: [FLINK-6268] [core] Object reuse for Either type
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3680
Additional changes look good as well :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3680: [FLINK-6268] [core] Object reuse for Either type
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3680
@zentol thanks for the review. I pushed a second commit to mark the added static methods as `@Internal` and renamed from `asLeft/Right` to `obtainLeft/Right`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3680: [FLINK-6268] [core] Object reuse for Either type
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3680
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---