You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "lincoln-lil (via GitHub)" <gi...@apache.org> on 2024/03/18 09:16:46 UTC
[PR] [FLINK-34707][tests] Update base version for japicmp check [flink]
lincoln-lil opened a new pull request, #24515:
URL: https://github.com/apache/flink/pull/24515
This is japicmp configuration update for master branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34707][tests] Update base version for japicmp check [flink]
Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil commented on PR #24515:
URL: https://github.com/apache/flink/pull/24515#issuecomment-2005888004
@JingGe @Myasuka @MartijnVisser Can someone of you help review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34707][tests] Update base version for japicmp check [flink]
Posted by "Myasuka (via GitHub)" <gi...@apache.org>.
Myasuka commented on code in PR #24515:
URL: https://github.com/apache/flink/pull/24515#discussion_r1529796588
##########
pom.xml:
##########
@@ -2358,12 +2358,6 @@ under the License.
<exclude>@org.apache.flink.annotation.PublicEvolving</exclude>
<exclude>@org.apache.flink.annotation.Internal</exclude>
<!-- MARKER: start exclusions; these will be wiped by tools/releasing/update_japicmp_configuration.sh -->
Review Comment:
If we could drop the exclusions, do we still need the markers here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34707][tests] Update base version for japicmp check [flink]
Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil commented on code in PR #24515:
URL: https://github.com/apache/flink/pull/24515#discussion_r1533840206
##########
pom.xml:
##########
@@ -2358,12 +2358,6 @@ under the License.
<exclude>@org.apache.flink.annotation.PublicEvolving</exclude>
<exclude>@org.apache.flink.annotation.Internal</exclude>
<!-- MARKER: start exclusions; these will be wiped by tools/releasing/update_japicmp_configuration.sh -->
Review Comment:
This marker is used for location by the script, see: https://github.com/apache/flink/blob/release-1.19/tools/releasing/update_japicmp_configuration.sh#L63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34707][tests] Update base version for japicmp check [flink]
Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil merged PR #24515:
URL: https://github.com/apache/flink/pull/24515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34707][tests] Update base version for japicmp check [flink]
Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil commented on PR #24515:
URL: https://github.com/apache/flink/pull/24515#issuecomment-2012246995
@Myasuka Thanks for reviewing! Please help review the cherry-pick one: https://github.com/apache/flink/pull/24514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34707][tests] Update base version for japicmp check [flink]
Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil commented on PR #24515:
URL: https://github.com/apache/flink/pull/24515#issuecomment-2005887137
@JingGe @Myasuka @MartijnVisser Can someone of you help review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34707][tests] Update base version for japicmp check [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24515:
URL: https://github.com/apache/flink/pull/24515#issuecomment-2003309967
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd1e3af417cefbdf0337eadb0bfbe47aa4a8ca02",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cd1e3af417cefbdf0337eadb0bfbe47aa4a8ca02",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd1e3af417cefbdf0337eadb0bfbe47aa4a8ca02 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org