You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2012/06/07 02:53:23 UTC
[jira] [Updated] (HADOOP-8488) test-patch.sh gives +1 even if the
native build fails.
[ https://issues.apache.org/jira/browse/HADOOP-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8488:
-----------------------------------------
Issue Type: Bug (was: Improvement)
Summary: test-patch.sh gives +1 even if the native build fails. (was: when Jenkins tests a patch, it should compile with -Pnative )
> test-patch.sh gives +1 even if the native build fails.
> ------------------------------------------------------
>
> Key: HADOOP-8488
> URL: https://issues.apache.org/jira/browse/HADOOP-8488
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Priority: Minor
>
> It would be nice if Jenkins would compile with mvn compile -Pnative or a similar command line.
> Currently, we don't seem to build the native code at all when testing patches. Unfortunately, this allows patches that break the native parts of the build to go in without the usual testing.
> It's true that the Jenkins build would not catch all native code issues (it only compiles in one environment, and there may be #ifdefs). However, some testing is sure better than none. I believe with cmake the performance overhead of -Pnative should be very minimal.
> This would also allow us to run the junit tests which depend on native code, and the raw native unit tests in Jenkins.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira