You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/05 09:20:33 UTC

[GitHub] dongjoon-hyun commented on a change in pull request #23444: [SPARK-26529]Add debug logs for confArchive when preparing local resource

dongjoon-hyun commented on a change in pull request #23444: [SPARK-26529]Add debug logs for confArchive when preparing local resource
URL: https://github.com/apache/spark/pull/23444#discussion_r245472336
 
 

 ##########
 File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
 ##########
 @@ -728,6 +728,7 @@ private[spark] class Client(
       new File(Utils.getLocalDir(sparkConf)))
     val confStream = new ZipOutputStream(new FileOutputStream(confArchive))
 
+    logDebug(s"Creating an archive with the config files for distribution at $confArchive.")
 
 Review comment:
   Hi, @liupc . Thank you for your first contribution.
   Please update the PR description. Currently, it still claims `IOException`.
   ```
   This PR will catch the IOException and print some useful information.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org