You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/10/10 12:05:17 UTC
[GitHub] [incubator-devlake] e2corporation opened a new issue, #3357: [Refactor][Config-UI] Fix Bug
e2corporation opened a new issue, #3357:
URL: https://github.com/apache/incubator-devlake/issues/3357
## What and why to refactor
PR #3191 created an unresolved dependency warning that needs to be resolved. This area needs to be refactored to revert changes made to Deployment Transformations behavior.
- Creating [object] and [undefined] Entries in main Transformations Map due to use of entityIdKey within an Effect instead of the original handler I had implemented.
- Improper use of controlled input switching from undefined to a controlled value during its lifecycle.
<img width="800" alt="192792968-ff073739-098a-4817-b462-1624698659fb" src="https://user-images.githubusercontent.com/1742233/194862459-f28a55ba-4e61-48b2-8a68-f47e7a8e74ff.png">
<img width="1355" alt="193159592-bc0bdc6a-6883-433e-a628-214dcd30365c" src="https://user-images.githubusercontent.com/1742233/194862455-0c4aefe5-7a1b-4dd1-a202-82c090cb0e2a.png">
## Describe the solution you'd like
How to refactor?
## Related issues
#3191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3357: [Refactor][Config-UI] DORA Deployment Transformation Options
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3357:
URL: https://github.com/apache/incubator-devlake/issues/3357#issuecomment-1273233347
@likyh Please review my feedback on this PR https://github.com/apache/incubator-devlake/pull/3191 and apply your own suggestions in the process to fix the issues outlined in this ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3357: [Refactor][Config-UI] DORA Deployment Transformation Options
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3357:
URL: https://github.com/apache/incubator-devlake/issues/3357#issuecomment-1282881308
Should be resolved with PR #3371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation closed issue #3357: [Refactor][Config-UI] DORA Deployment Transformation Options
Posted by GitBox <gi...@apache.org>.
e2corporation closed issue #3357: [Refactor][Config-UI] DORA Deployment Transformation Options
URL: https://github.com/apache/incubator-devlake/issues/3357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org