You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/07 08:25:30 UTC

[GitHub] [spark] zero323 commented on pull request #34203: [SPARK-36944][PYTHON] Remove unused python/pyspark/sql/__init__.pyi

zero323 commented on pull request #34203:
URL: https://github.com/apache/spark/pull/34203#issuecomment-937568298


   Technically speaking, it is not unused. Type checkers should prefer type information from stubs over ones collected from `py` files. So in the current state, mypy will read information from `__init__.pyi` and ignore actual implementation. If you remove it, mypy will switch to analysing `__init__.py`.
   
   That being said, in this case it should be OK to simply remove.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org