[GitHub] eric-haibin-lin commented on a change in pull request #10845: [MXNET-406] support init/pull dense weight, push row_sparse grad in kvstore

[GitBox <gi...@apache.org>]

eric-haibin-lin commented on a change in pull request #10845: [MXNET-406] support init/pull dense weight, push row_sparse grad in kvstore
URL: https://github.com/apache/incubator-mxnet/pull/10845#discussion_r187671505
 
 

 ##########
 File path: src/kvstore/comm.h
 ##########
 @@ -228,7 +244,11 @@ class CommCPU : public Comm {
       NDArray retained_cpu = (is_same_ctx && is_diff_var) ? *out :
           NDArray(kRowSparseStorage, src.shape(), src.ctx(), true,
                   src.dtype(), src.aux_types());
-
+      if (!is_diff_var) {
+        common::LogOnce("The output of row_sparse_pull on key " + std::to_string(key) +
+                        "refers to the same NDArray as the one stored in KVStore."
+                        "Incorrect result may be generated.");
 
 Review comment:
   Good point. I added some explanation and steps to avoid this in the message. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services