You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/04/30 00:37:15 UTC

[GitHub] [skywalking] hanahmily commented on issue #2560: Standardize Time in SkyWalking

hanahmily commented on issue #2560: Standardize Time in SkyWalking
URL: https://github.com/apache/skywalking/issues/2560#issuecomment-487790119
 
 
   > Agent reports its timezone in register and heartbeat, in default, treated as backend timezone for back-forward compatible. But I hope Java, .net, nodejs, php, go agents could adopte this.
   If we use gRPC, I think the best practice is that at the first segment of streaming the agent is designed to report timezone.
   > Service Mesh receiver, especially istio and envoy receiver need to transfer time based on timezone in the timestamp. @hanahmily <https://github.com/hanahmily>For service mesh, eg. istio mixer,envoy, there’s no chance to grab timezone of senders. But a good news for us is they are both deployed in docker whose default timezone is GTM(UTC-0), especially envoy’s access log is [designed to support it](https://github.com/envoyproxy/envoy/issues/3546 <https://github.com/envoyproxy/envoy/issues/3546>).So the details should be declared in our documents.
   
   
   
   
   > On Apr 30, 2019, at 8:08 AM, 吴晟 Wu Sheng <no...@github.com> wrote:
   > 
   > Hi
   > 
   > Today, SkyWalking time mechanism relied on the agent, backend, and UI in the same time zone, but still facing issues. Because of the time in agent traces, it is hard to make it accurate in the query.
   > 
   > In 6.2, I want to do this, which related to agent, backend and UI changes.
   > 
   > Agent reports its timezone in register and heartbeat, in default, treated as backend timezone for back-forward compatible. But I hope Java, .net, nodejs, php, go agents could adopte this. @ascrutae <https://github.com/ascrutae> @liuhaoyang <https://github.com/liuhaoyang> @hanahmily <https://github.com/hanahmily> @heyanlong <https://github.com/heyanlong>
   > Service Mesh receiver, especially istio and envoy receiver need to transfer time based on timezone in the timestamp. @hanahmily <https://github.com/hanahmily>
   > OAP backend will transfer time format to UTC-0 always and save in storage.
   > OAP query parameter and result are all based on UTC-0, UI needs to change time visualization based on browser timezone. Also, because of this, I think no need to choose timezone anymore. @TinyAllen <https://github.com/TinyAllen>
   > —
   > You are receiving this because you were assigned.
   > Reply to this email directly, view it on GitHub <https://github.com/apache/skywalking/issues/2560>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAO6UWNK7H3W3ZGYSAQCDR3PS6EYZANCNFSM4HJHT5KA>.
   > 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services