You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/26 11:09:53 UTC
[GitHub] [incubator-doris] acelyc111 opened a new pull request #4458: [Bug] Fix bug that memory copy may overflow in MemIndex::load_segment
acelyc111 opened a new pull request #4458:
URL: https://github.com/apache/incubator-doris/pull/4458
## Proposed changes
Segment index file content is not set as 0 when it is constructed in write procedure, so when load index from this file, and meet a null VARCHAR cell, the null field of this cell is 0, but the length field which is not initialized maybe a large random number, then memory copy may cause overflow.
This patch fix this bug, and also skip useless memory copy to improve a bit of performance.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [] Any dependent changes have been merged
## Further comments
none
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] acelyc111 commented on pull request #4458: [Bug] Fix bug that memory copy may overflow in MemIndex::load_segment
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on pull request #4458:
URL: https://github.com/apache/incubator-doris/pull/4458#issuecomment-682721404
> I'm curious, why hasn't this part of the code been a problem before?
> It looks like this code has been around for a long time.
I'm not clear, this issue will only happened when the value is null, and nullable byte is correctly copied
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4458: [Bug] Fix bug that memory copy may overflow in MemIndex::load_segment
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4458:
URL: https://github.com/apache/incubator-doris/pull/4458#issuecomment-682360636
I'm curious, why hasn't this part of the code been a problem before?
It looks like this code has been around for a long time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4458: [Bug] Fix bug that memory copy may overflow in MemIndex::load_segment
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4458:
URL: https://github.com/apache/incubator-doris/pull/4458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org