[GitHub] [beam] nbali commented on a diff in pull request #16909: Introducing KafkaIO.Read implementation compatibility testing

[GitBox <gi...@apache.org>]

nbali commented on code in PR #16909:
URL: https://github.com/apache/beam/pull/16909#discussion_r849969255


##########
sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOReadImplementationCompatibilityTest.java:
##########
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.kafka;
+
+import static org.apache.beam.sdk.io.kafka.KafkaIOTest.mkKafkaReadTransform;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.empty;
+import static org.hamcrest.Matchers.is;
+import static org.hamcrest.Matchers.notNullValue;
+
+import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
+import java.util.Set;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+import org.apache.beam.sdk.io.kafka.KafkaIOReadImplementationCompatibility.KafkaIOReadProperties;
+import org.apache.beam.sdk.io.kafka.KafkaIOTest.ValueAsTimestampFn;
+import org.apache.beam.sdk.testing.TestPipeline;
+import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.CaseFormat;
+import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Sets;
+import org.joda.time.Duration;
+import org.joda.time.Instant;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+
+@RunWith(JUnit4.class)
+public class KafkaIOReadImplementationCompatibilityTest {
+
+  @Rule public final transient TestPipeline p = TestPipeline.create();
+
+  @Rule public ExpectedException thrown = ExpectedException.none();
+
+  @Test
+  public void testKafkaIOReadPropertiesEnumValuePresence() {
+    final Set<String> properties = getGetterPropertyNamesInUpperUnderscore(KafkaIO.Read.class);
+    final Set<String> enums = getEnumValueNamesInUpperUnderscore(KafkaIOReadProperties.class);
+
+    final Sets.SetView<String> missingEnums = Sets.difference(properties, enums);
+    final Sets.SetView<String> unnecessaryEnums = Sets.difference(enums, properties);
+
+    assertThat("There are missing 'KafkaIOReadProperties' enum values!", missingEnums, is(empty()));
+    assertThat(
+        "There are unnecessary 'KafkaIOReadProperties' enum values present!",
+        unnecessaryEnums,
+        is(empty()));
+  }
+
+  private static Set<String> getGetterPropertyNamesInUpperUnderscore(Class<?> clazz) {
+    final Set<String> result = Sets.newLinkedHashSet();
+    for (Method method : clazz.getDeclaredMethods()) {
+      if (!Modifier.isStatic(method.getModifiers())) {
+        if (!Void.TYPE.equals(method.getReturnType())) {
+          if (method.getParameterCount() == 0) {
+            for (String prefix : new String[] {"get", "is"}) {
+              final String methodName = method.getName();
+              if (methodName.startsWith(prefix) && methodName.length() > prefix.length()) {
+                final String propertyName = methodName.substring(prefix.length());
+                result.add(CaseFormat.UPPER_CAMEL.to(CaseFormat.UPPER_UNDERSCORE, propertyName));
+              }
+            }
+          }
+        }
+      }
+    }
+    return result;
+  }
+
+  private static Set<String> getEnumValueNamesInUpperUnderscore(
+      Class<? extends Enum<?>> enumClazz) {
+    return Stream.of(enumClazz.getEnumConstants()).map(Enum::name).collect(Collectors.toSet());

Review Comment:
   I gotta say these tests are rather flaky. (Just check which ones failed during the last 3 commit.) Anyway it all seems to pass now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org