You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Zuyu Zhang <hi...@gmail.com> on 2014/06/21 18:30:42 UTC

Re: Review Request 22539: Add the low level scheduler examples, implemented using libprocess or pthread.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/
-----------------------------------------------------------

(Updated June 21, 2014, 4:30 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Summary (updated)
-----------------

Add the low level scheduler examples, implemented using libprocess or pthread.


Repository: mesos-git


Description (updated)
-------

Add the low level scheduler examples


Diffs (updated)
-----

  src/Makefile.am a87eb211e9b153098b451313c977c80bf1ae0cc4 
  src/examples/low_level_scheduler.cpp PRE-CREATION 
  src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
  src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
  src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 
  src/tests/low_level_scheduler_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/22539/diff/


Testing (updated)
-------

[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from ExamplesTest
[ RUN      ] ExamplesTest.LowLevelScheduler
[       OK ] ExamplesTest.LowLevelScheduler (1647 ms)
[ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
[       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1698 ms)
[----------] 2 tests from ExamplesTest (3345 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (3360 ms total)
[  PASSED  ] 2 tests.


Thanks,

Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler examples, implemented using libprocess or pthread.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/#review46529
-----------------------------------------------------------


Bad patch!

Reviews applied: [22539]

Failed command: ./support/mesos-style.py

Error:
 Checking 482 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
src/tests/examples_tests.cpp:28:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
Total errors found: 1


- Mesos ReviewBot


On June 21, 2014, 4:30 p.m., Zuyu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22539/
> -----------------------------------------------------------
> 
> (Updated June 21, 2014, 4:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add the low level scheduler examples
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a87eb211e9b153098b451313c977c80bf1ae0cc4 
>   src/examples/low_level_scheduler.cpp PRE-CREATION 
>   src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
>   src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
>   src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 
>   src/tests/low_level_scheduler_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22539/diff/
> 
> 
> Testing
> -------
> 
> [==========] Running 2 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 2 tests from ExamplesTest
> [ RUN      ] ExamplesTest.LowLevelScheduler
> [       OK ] ExamplesTest.LowLevelScheduler (1647 ms)
> [ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
> [       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1698 ms)
> [----------] 2 tests from ExamplesTest (3345 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 2 tests from 1 test case ran. (3360 ms total)
> [  PASSED  ] 2 tests.
> 
> 
> Thanks,
> 
> Zuyu Zhang
> 
>

Re: Review Request 22539: Add the low level scheduler examples, implemented using libprocess or pthread.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/#review46574
-----------------------------------------------------------


Hey Zuyu, let's start with a review for the libprocess based low level scheduler example. I've included some comments in this review but please pull out the pthread example so we can get them reviewed and committed separately (and more quickly!).


src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82027>

    Let's start in the DISCONNECTED state, is there a difference between DISCONNECTED and CONNECTING?



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82028>

    Let's move to a CONNECTED state in this method. That should control when we should be sending REGISTER messages.
    
    If we're disconnected, let's not send any REGISTER message to the master.



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82057>

    Do we need this?



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82064>

    What is an 'ev'? ;)
    
    s/ev/event/



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82059>

    Let's consistently not use periods at the end of the log messages (some of your messages have periods and some don't).



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82060>

    "Slave " << ... << " failed";



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82061>

    Please look at the executor id first as the slave id will be set when an executor failure is provided:
    
    Executor failure: slave_id and executor_id set
    
    Slave failure: slave_id set
    
    Also you can say:
    
    "Executor <id> failed on slave <id>"



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82062>

    This will only be set when executor id and slave id is set.



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82063>

    You should terminate if an error is encountered.



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82056>

    Let's remove this method and just use the << operator of the 'Resources' type from resources.hpp. Then we can easily print the resources inside 'recourceOffers'.



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82054>

    * on the type:
    
    Call::Launch* launch = ...;
    
    Here and everywhere else.



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82029>

    Let's just print similarly to how we print in test_framework.cpp so no need to print the message and data here.



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82026>

    s/doReliableConnecting/doReliableRegistration/
    
    Let's also use "registered" in place of "connected" as the two are not the same (connected() callback does not mean registered).



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82030>

    Instead of having a done() function, can we just use finalize() (which is called when the process is terminated).
    
    That way, calls to 'done()' can be replaced with 'terminate(self())' and then we can send UNREGISTER from inside finalize().



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82025>

    Let's rename these to match the actual states:
    
    DISCONNECTED = 0
    CONNECTED = 1
    REGISTERED = 2



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82024>

    Doesn't look like we need the DONE state?


- Ben Mahler


On June 24, 2014, 3:44 p.m., Zuyu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22539/
> -----------------------------------------------------------
> 
> (Updated June 24, 2014, 3:44 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add the low level scheduler examples
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 861aad264e89ae062d26b45f7dd3be1bc1a6d2cc 
>   src/examples/low_level_scheduler.cpp PRE-CREATION 
>   src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
>   src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
>   src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 
>   src/tests/low_level_scheduler_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22539/diff/
> 
> 
> Testing
> -------
> 
> [==========] Running 2 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 2 tests from ExamplesTest
> [ RUN      ] ExamplesTest.LowLevelScheduler
> [       OK ] ExamplesTest.LowLevelScheduler (1647 ms)
> [ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
> [       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1698 ms)
> [----------] 2 tests from ExamplesTest (3345 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 2 tests from 1 test case ran. (3360 ms total)
> [  PASSED  ] 2 tests.
> 
> 
> Thanks,
> 
> Zuyu Zhang
> 
>

Re: Review Request 22539: Add the low level scheduler example using libprocess

Posted by Zuyu Zhang <hi...@gmail.com>.

> On June 30, 2014, 10:08 p.m., Vinod Kone wrote:
> > src/Makefile.am, line 955
> > <https://reviews.apache.org/r/22539/diff/9/?file=619384#file619384line955>
> >
> >     All our example frameworks use libprocess. Did you add the "libprocess" suffix because you are planning to write other example frameworks that don't use libprocess? if not, kill that suffix.

There will be a pthread version with a new review thread.


> On June 30, 2014, 10:08 p.m., Vinod Kone wrote:
> > src/tests/examples_tests.cpp, line 27
> > <https://reviews.apache.org/r/22539/diff/9/?file=619386#file619386line27>
> >
> >     s/Libprocess//

Reserved for another pthread version.


> On June 30, 2014, 10:08 p.m., Vinod Kone wrote:
> > src/tests/examples_tests.cpp, line 28
> > <https://reviews.apache.org/r/22539/diff/9/?file=619386#file619386line28>
> >
> >     s/libprocess//

See above.


> On June 30, 2014, 10:08 p.m., Vinod Kone wrote:
> > src/examples/low_level_scheduler_libprocess.cpp, line 328
> > <https://reviews.apache.org/r/22539/diff/9/?file=619385#file619385line328>
> >
> >     Can this be const?

No, because we need a const version of scheduler::Mesos::send.


- Zuyu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/#review47018
-----------------------------------------------------------


On June 27, 2014, 12:47 p.m., Zuyu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22539/
> -----------------------------------------------------------
> 
> (Updated June 27, 2014, 12:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add the low level scheduler example using libprocess
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 902792782e760d5e0a73fb7aa72aef003c0af9c0 
>   src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
>   src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
>   src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22539/diff/
> 
> 
> Testing
> -------
> 
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from ExamplesTest
> [ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
> [       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1670 ms)
> [----------] 1 test from ExamplesTest (1670 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1684 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Zuyu Zhang
> 
>

Re: Review Request 22539: Add the low level scheduler example using libprocess

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/#review47018
-----------------------------------------------------------


looks good. some minor fixes before we can commit this.


src/Makefile.am
<https://reviews.apache.org/r/22539/#comment82614>

    All our example frameworks use libprocess. Did you add the "libprocess" suffix because you are planning to write other example frameworks that don't use libprocess? if not, kill that suffix.



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82616>

    s/to/with/



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82617>

    How about:
    
    TODO(zuyu): Do batch processing of UPDATE events.



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82618>

    s/failed/terminated/



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82619>

    s/failed/terminated/



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82620>

    This should be CHECK because this is not possible.



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82621>

    Describe what you are printing.
    
    Also include Offer id.



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82622>

    s/task_info/taskInfo/



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82623>

    end the comment with period.



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/22539/#comment82615>

    Can this be const?



src/tests/examples_tests.cpp
<https://reviews.apache.org/r/22539/#comment82624>

    s/Libprocess//



src/tests/examples_tests.cpp
<https://reviews.apache.org/r/22539/#comment82625>

    s/libprocess//


- Vinod Kone


On June 27, 2014, 12:47 p.m., Zuyu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22539/
> -----------------------------------------------------------
> 
> (Updated June 27, 2014, 12:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add the low level scheduler example using libprocess
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 902792782e760d5e0a73fb7aa72aef003c0af9c0 
>   src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
>   src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
>   src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22539/diff/
> 
> 
> Testing
> -------
> 
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from ExamplesTest
> [ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
> [       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1670 ms)
> [----------] 1 test from ExamplesTest (1670 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1684 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Zuyu Zhang
> 
>

Re: Review Request 22539: Add the low level scheduler example using libprocess

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/#review46936
-----------------------------------------------------------


Patch looks great!

Reviews applied: [22539]

All tests passed.

- Mesos ReviewBot


On June 27, 2014, 12:47 p.m., Zuyu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22539/
> -----------------------------------------------------------
> 
> (Updated June 27, 2014, 12:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add the low level scheduler example using libprocess
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 902792782e760d5e0a73fb7aa72aef003c0af9c0 
>   src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
>   src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
>   src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22539/diff/
> 
> 
> Testing
> -------
> 
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from ExamplesTest
> [ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
> [       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1670 ms)
> [----------] 1 test from ExamplesTest (1670 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1684 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Zuyu Zhang
> 
>

Re: Review Request 22539: Add the low level scheduler example using libprocess

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/#review47036
-----------------------------------------------------------


Patch looks great!

Reviews applied: [22539]

All tests passed.

- Mesos ReviewBot


On July 1, 2014, 12:58 a.m., Zuyu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22539/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 12:58 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add the low level scheduler example using libprocess
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 918b0d04a5de69a9213e3d31c8f9424756e4ade5 
>   src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
>   src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
>   src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22539/diff/
> 
> 
> Testing
> -------
> 
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from ExamplesTest
> [ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
> [       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1670 ms)
> [----------] 1 test from ExamplesTest (1670 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1684 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Zuyu Zhang
> 
>

Re: Review Request 22539: Add the low level scheduler example using libprocess

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/#review47116
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On July 1, 2014, 12:58 a.m., Zuyu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22539/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 12:58 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add the low level scheduler example using libprocess
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 918b0d04a5de69a9213e3d31c8f9424756e4ade5 
>   src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
>   src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
>   src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22539/diff/
> 
> 
> Testing
> -------
> 
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from ExamplesTest
> [ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
> [       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1670 ms)
> [----------] 1 test from ExamplesTest (1670 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (1684 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Zuyu Zhang
> 
>

Re: Review Request 22539: Add the low level scheduler example using libprocess

Posted by Zuyu Zhang <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/
-----------------------------------------------------------

(Updated July 1, 2014, 12:58 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Repository: mesos-git


Description
-------

Add the low level scheduler example using libprocess


Diffs (updated)
-----

  src/Makefile.am 918b0d04a5de69a9213e3d31c8f9424756e4ade5 
  src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
  src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
  src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/22539/diff/


Testing
-------

[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ExamplesTest
[ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
[       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1670 ms)
[----------] 1 test from ExamplesTest (1670 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1684 ms total)
[  PASSED  ] 1 test.


Thanks,

Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler example using libprocess

Posted by Zuyu Zhang <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/
-----------------------------------------------------------

(Updated June 27, 2014, 12:47 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Repository: mesos-git


Description
-------

Add the low level scheduler example using libprocess


Diffs
-----

  src/Makefile.am 902792782e760d5e0a73fb7aa72aef003c0af9c0 
  src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
  src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
  src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/22539/diff/


Testing
-------

[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ExamplesTest
[ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
[       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1670 ms)
[----------] 1 test from ExamplesTest (1670 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1684 ms total)
[  PASSED  ] 1 test.


Thanks,

Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler example using libprocess

Posted by Zuyu Zhang <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/
-----------------------------------------------------------

(Updated June 27, 2014, 12:47 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Repository: mesos-git


Description
-------

Add the low level scheduler example using libprocess


Diffs
-----

  src/Makefile.am 902792782e760d5e0a73fb7aa72aef003c0af9c0 
  src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
  src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
  src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/22539/diff/


Testing
-------

[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ExamplesTest
[ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
[       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1670 ms)
[----------] 1 test from ExamplesTest (1670 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1684 ms total)
[  PASSED  ] 1 test.


Thanks,

Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler example using libprocess

Posted by Zuyu Zhang <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/
-----------------------------------------------------------

(Updated June 27, 2014, 12:46 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Changes
-------

Fixed a typo in Makefile.am


Repository: mesos-git


Description
-------

Add the low level scheduler example using libprocess


Diffs (updated)
-----

  src/Makefile.am 902792782e760d5e0a73fb7aa72aef003c0af9c0 
  src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
  src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
  src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/22539/diff/


Testing
-------

[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ExamplesTest
[ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
[       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1670 ms)
[----------] 1 test from ExamplesTest (1670 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1684 ms total)
[  PASSED  ] 1 test.


Thanks,

Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler example using libprocess

Posted by Zuyu Zhang <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/
-----------------------------------------------------------

(Updated June 27, 2014, 12:51 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Repository: mesos-git


Description
-------

Add the low level scheduler example using libprocess


Diffs
-----

  src/Makefile.am 902792782e760d5e0a73fb7aa72aef003c0af9c0 
  src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
  src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
  src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/22539/diff/


Testing
-------

[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ExamplesTest
[ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
[       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1670 ms)
[----------] 1 test from ExamplesTest (1670 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1684 ms total)
[  PASSED  ] 1 test.


Thanks,

Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler example using libprocess

Posted by Zuyu Zhang <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/
-----------------------------------------------------------

(Updated June 27, 2014, 12:51 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Repository: mesos-git


Description
-------

Add the low level scheduler example using libprocess


Diffs (updated)
-----

  src/Makefile.am 902792782e760d5e0a73fb7aa72aef003c0af9c0 
  src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
  src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
  src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/22539/diff/


Testing
-------

[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ExamplesTest
[ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
[       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1670 ms)
[----------] 1 test from ExamplesTest (1670 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1684 ms total)
[  PASSED  ] 1 test.


Thanks,

Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler example using libprocess

Posted by Zuyu Zhang <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/
-----------------------------------------------------------

(Updated June 26, 2014, 6:55 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Summary (updated)
-----------------

Add the low level scheduler example using libprocess


Repository: mesos-git


Description (updated)
-------

Add the low level scheduler example using libprocess


Diffs (updated)
-----

  src/Makefile.am 3c8b91a2ef4f90137bc7f049c31295bb198ef766 
  src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
  src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
  src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/22539/diff/


Testing (updated)
-------

[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ExamplesTest
[ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
[       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1670 ms)
[----------] 1 test from ExamplesTest (1670 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1684 ms total)
[  PASSED  ] 1 test.


Thanks,

Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler examples, implemented using libprocess or pthread.

Posted by Zuyu Zhang <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22539/
-----------------------------------------------------------

(Updated June 24, 2014, 3:44 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

Updated the code style.


Repository: mesos-git


Description
-------

Add the low level scheduler examples


Diffs (updated)
-----

  src/Makefile.am 861aad264e89ae062d26b45f7dd3be1bc1a6d2cc 
  src/examples/low_level_scheduler.cpp PRE-CREATION 
  src/examples/low_level_scheduler_libprocess.cpp PRE-CREATION 
  src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 
  src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION 
  src/tests/low_level_scheduler_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/22539/diff/


Testing
-------

[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from ExamplesTest
[ RUN      ] ExamplesTest.LowLevelScheduler
[       OK ] ExamplesTest.LowLevelScheduler (1647 ms)
[ RUN      ] ExamplesTest.LowLevelSchedulerLibprocess
[       OK ] ExamplesTest.LowLevelSchedulerLibprocess (1698 ms)
[----------] 2 tests from ExamplesTest (3345 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (3360 ms total)
[  PASSED  ] 2 tests.


Thanks,

Zuyu Zhang