[jira] [Work logged] (KNOX-2795) Handling missing OIDC client name parameter

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KNOX-2795?focusedWorklogId=803577&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803577 ]

ASF GitHub Bot logged work on KNOX-2795:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Aug/22 11:40
            Start Date: 25/Aug/22 11:40
    Worklog Time Spent: 10m 
      Work Description: zeroflag opened a new pull request, #626:
URL: https://github.com/apache/knox/pull/626

   ## What changes were proposed in this pull request?
   
   The client name config parameter was handled in an inconsistent manner.
   
    * When it was null we threw an exception saying that this parameter is mandatory
    * However when it was an empty string, we did fallback using the default client name coming from the provider
   
   I removed the null check so that we use the default in that case too.
   
   ## How was this patch tested?
   
   Manually tested with a topology like this:
   
   ```xml
         <provider>
             <role>federation</role>
             <name>pac4j</name>
             <enabled>true</enabled>
             <param>
               <name>pac4j.callbackUrl</name>
               <value>https://localhost:8443/gateway/knoxsso/api/v1/websso</value>
             </param>
   <!

Issue Time Tracking
-------------------

            Worklog Id:     (was: 803577)
    Remaining Estimate: 0h
            Time Spent: 10m

> Handling missing OIDC client name parameter 
> --------------------------------------------
>
>                 Key: KNOX-2795
>                 URL: https://issues.apache.org/jira/browse/KNOX-2795
>             Project: Apache Knox
>          Issue Type: Improvement
>            Reporter: Attila Magyar
>            Assignee: Attila Magyar
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently if the parameter is missing (=null) we throw an exception saying that this paramter is mandatory. However if the param is an empty string we default to the pac4j provided parameter.
> We should probably remove the null check and use the default in that case too.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)