You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "nielm (via GitHub)" <gi...@apache.org> on 2024/10/08 19:42:59 UTC

[PR] Revert "Set setFailIfPoolExhausted in SessionPoolOptions for SpannerAccessor" [beam]

nielm opened a new pull request, #32702:
URL: https://github.com/apache/beam/pull/32702

   Cherry-pick of #31663 for release 2.60 
   
   Addresses Bug #32697
   
   This reverts commit efee92bf02b55bee86848a9d0d291de58cb8412a.
   
   Specific cause:
   
   Spanner has a max number of 400 sessions in a session pool, where a session is used for a read or a write operation.
   
   When using streaming pipelines on Dataflow with a high degree of parallelisation, where each work item can be reading from and writing to spanner, Dataflow will have up to 300 threads per worker, which potentially means 300 simultaneous read sessions, and 300 simultaneous downstream writes.
   
   In some scenarios, this can lead to session pool exhaustion, followed by a worker failing due to this flag.
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "Set setFailIfPoolExhausted in SessionPoolOptions for SpannerAccessor" [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32702:
URL: https://github.com/apache/beam/pull/32702#issuecomment-2400687532

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "Set setFailIfPoolExhausted in SessionPoolOptions for SpannerAccessor" [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #32702:
URL: https://github.com/apache/beam/pull/32702


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "Set setFailIfPoolExhausted in SessionPoolOptions for SpannerAccessor" [beam]

Posted by "nielm (via GitHub)" <gi...@apache.org>.
nielm commented on PR #32702:
URL: https://github.com/apache/beam/pull/32702#issuecomment-2400685401

   R: @Abacn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org