[jira] [Commented] (FLINK-12189) Fix bugs and typos in memory management related code

["Liya Fan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819706#comment-16819706 ] 

Liya Fan commented on FLINK-12189:
----------------------------------

To make the PR easier to understand to review, I have split the bugs into separate JIRAs, and provide UTs and PRs separately. 

> Fix bugs and typos in memory management related code
> ----------------------------------------------------
>
>                 Key: FLINK-12189
>                 URL: https://issues.apache.org/jira/browse/FLINK-12189
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Operators
>            Reporter: Liya Fan
>            Assignee: Liya Fan
>            Priority: Critical
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There are some bugs and typos in the memory related source code. For example,
>  # In MemoryManager.release method, it should throw an NPE, if the input is null. But it does not. 
>  # In HybridMemorySegment.put and get methods, the number of bytes read/written should be specified by the input parameter, rather than reading/writing until the end.
>  # In HeapMemorySegment, the data member memory should be returned. This is because the member heapArray will not be reset to null after calling the release method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)