You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/01/24 19:34:10 UTC
Review Request 65316: Added test for delayed authorization during
operator events.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
Bugs: MESOS-8469
https://issues.apache.org/jira/browse/MESOS-8469
Repository: mesos
Description
-------
Added test for delayed authorization during operator events.
Diffs
-----
src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94
Diff: https://reviews.apache.org/r/65316/diff/1/
Testing
-------
Confirmed that the test fails without the fix for MESOS-8469.
When the fix is included, the test passes. Successfully ran `` to rule out any flakiness.
Thanks,
Greg Mann
Re: Review Request 65316: Added test for delayed authorization during
operator events.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/#review196165
-----------------------------------------------------------
FAIL: Mesos tests failed to build.
Reviews applied: `['65315', '65316']`
Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65316
Relevant logs:
- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65316/logs/mesos-tests-build-cmake-stdout.log):
```
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363): warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _strdup. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377): warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _stricmp. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189): warning C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278): warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _stricmp. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(289): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(290): warning C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(293): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(138): warning C4477: 'snprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 1 has type 'time_t' [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(157): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\plugins\cram.c(293): warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj] [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (12) ->
(ClCompile target) ->
D:\DCOS\mesos\mesos\src\executor\executor.cpp(233): error C2039: 'eraseenv': is not a member of 'os' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\executor\executor.cpp(233): error C3861: 'eraseenv': identifier not found [D:\DCOS\mesos\src\mesos.vcxproj]
112 Warning(s)
2 Error(s)
Time Elapsed 00:03:20.37
```
- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65316/logs/mesos-tests-CMakeOutput.log):
```
Creating directory "cmTC_03192.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_03192.dir\Debug\cmTC_03192.tlog\".
InitializeBuildStatus:
Creating "cmTC_03192.dir\Debug\cmTC_03192.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_03192.dir\Debug\" /Fd"cmTC_03192.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_03192.dir\Debug\" /Fd"cmTC_03192.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_03192.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_03192.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_03192.lib" /MACHINE:X64 /machine:x64 cmTC_03192.dir\Debug\src.obj
cmTC_03192.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_03192.exe
FinalizeBuildStatus:
Deleting file "cmTC_03192.dir\Debug\cmTC_03192.tlog\unsuccessfulbuild".
Touching "cmTC_03192.dir\Debug\cmTC_03192.tlog\cmTC_03192.lastbuildstate".
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_03192.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:01.24
Source file was:
int main() { return 0; }
```
- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65316/logs/mesos-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_92c83.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_92c83.dir\Debug\cmTC_92c83.tlog\".
InitializeBuildStatus:
Creating "cmTC_92c83.dir\Debug\cmTC_92c83.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_92c83.dir\Debug\" /Fd"cmTC_92c83.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_92c83.dir\Debug\" /Fd"cmTC_92c83.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_92c83.vcxproj]
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_92c83.vcxproj" (default targets) -- FAILED.
Build FAILED.
"D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_92c83.vcxproj" (default target) (1) ->
(ClCompile target) ->
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_92c83.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:00.67
```
- Mesos Reviewbot Windows
On Jan. 24, 2018, 8:04 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65316/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2018, 8:04 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8469
> https://issues.apache.org/jira/browse/MESOS-8469
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Until the fix for MESOS-8469, it was possible for the master
> operator event stream to drop events, if event-related state in
> the master changed in between asynchronous calls.
>
> This patch adds `MasterAPITest.EventAuthorizationDelayed` to
> verify the fix for that issue.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94
>
>
> Diff: https://reviews.apache.org/r/65316/diff/3/
>
>
> Testing
> -------
>
> Confirmed that the test fails without the fix for MESOS-8469.
>
> When the fix is included, the test passes. Successfully ran `bin/mesos-tests.sh --gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*" --gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65316: Added test for delayed authorization during
operator events.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/
-----------------------------------------------------------
(Updated Feb. 8, 2018, 2:26 a.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
Bugs: MESOS-8469
https://issues.apache.org/jira/browse/MESOS-8469
Repository: mesos
Description
-------
Until the fix for MESOS-8469, it was possible for the master
operator event stream to drop events, if event-related state in
the master changed in between asynchronous calls.
This patch adds `MasterAPITest.EventAuthorizationDelayed` to
verify the fix for that issue.
Diffs
-----
src/tests/api_tests.cpp b639a4bafbf69d3ea53aa0573e9f0489c3a1a57f
Diff: https://reviews.apache.org/r/65316/diff/4/
Testing
-------
Confirmed that the test fails without the fix for MESOS-8469.
When the fix is included, the test passes. Successfully ran `bin/mesos-tests.sh --gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*" --gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness.
Thanks,
Greg Mann
Re: Review Request 65316: Added test for delayed authorization during
operator events.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/#review196549
-----------------------------------------------------------
PASS: Mesos patch 65316 was successfully built and tested.
Reviews applied: `['65315', '65316']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65316
- Mesos Reviewbot Windows
On Jan. 31, 2018, 2:53 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65316/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2018, 2:53 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8469
> https://issues.apache.org/jira/browse/MESOS-8469
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Until the fix for MESOS-8469, it was possible for the master
> operator event stream to drop events, if event-related state in
> the master changed in between asynchronous calls.
>
> This patch adds `MasterAPITest.EventAuthorizationDelayed` to
> verify the fix for that issue.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp b639a4bafbf69d3ea53aa0573e9f0489c3a1a57f
>
>
> Diff: https://reviews.apache.org/r/65316/diff/4/
>
>
> Testing
> -------
>
> Confirmed that the test fails without the fix for MESOS-8469.
>
> When the fix is included, the test passes. Successfully ran `bin/mesos-tests.sh --gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*" --gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65316: Added test for delayed authorization during
operator events.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/
-----------------------------------------------------------
(Updated Jan. 31, 2018, 2:53 a.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
Bugs: MESOS-8469
https://issues.apache.org/jira/browse/MESOS-8469
Repository: mesos
Description
-------
Until the fix for MESOS-8469, it was possible for the master
operator event stream to drop events, if event-related state in
the master changed in between asynchronous calls.
This patch adds `MasterAPITest.EventAuthorizationDelayed` to
verify the fix for that issue.
Diffs (updated)
-----
src/tests/api_tests.cpp b639a4bafbf69d3ea53aa0573e9f0489c3a1a57f
Diff: https://reviews.apache.org/r/65316/diff/4/
Changes: https://reviews.apache.org/r/65316/diff/3-4/
Testing
-------
Confirmed that the test fails without the fix for MESOS-8469.
When the fix is included, the test passes. Successfully ran `bin/mesos-tests.sh --gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*" --gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness.
Thanks,
Greg Mann
Re: Review Request 65316: Added test for delayed authorization during
operator events.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/#review196379
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/api_tests.cpp
Lines 2630 (patched)
<https://reviews.apache.org/r/65316/#comment276008>
Remove this blank line.
- Gaston Kleiman
On Jan. 24, 2018, 12:04 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65316/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2018, 12:04 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8469
> https://issues.apache.org/jira/browse/MESOS-8469
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Until the fix for MESOS-8469, it was possible for the master
> operator event stream to drop events, if event-related state in
> the master changed in between asynchronous calls.
>
> This patch adds `MasterAPITest.EventAuthorizationDelayed` to
> verify the fix for that issue.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94
>
>
> Diff: https://reviews.apache.org/r/65316/diff/3/
>
>
> Testing
> -------
>
> Confirmed that the test fails without the fix for MESOS-8469.
>
> When the fix is included, the test passes. Successfully ran `bin/mesos-tests.sh --gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*" --gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65316: Added test for delayed authorization during
operator events.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/
-----------------------------------------------------------
(Updated Jan. 24, 2018, 8:04 p.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
Changes
-------
Addressed Gaston's comment.
Bugs: MESOS-8469
https://issues.apache.org/jira/browse/MESOS-8469
Repository: mesos
Description (updated)
-------
Until the fix for MESOS-8469, it was possible for the master
operator event stream to drop events, if event-related state in
the master changed in between asynchronous calls.
This patch adds `MasterAPITest.EventAuthorizationDelayed` to
verify the fix for that issue.
Diffs (updated)
-----
src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94
Diff: https://reviews.apache.org/r/65316/diff/3/
Changes: https://reviews.apache.org/r/65316/diff/2-3/
Testing
-------
Confirmed that the test fails without the fix for MESOS-8469.
When the fix is included, the test passes. Successfully ran `bin/mesos-tests.sh --gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*" --gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness.
Thanks,
Greg Mann
Re: Review Request 65316: Added test for delayed authorization during
operator events.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/
-----------------------------------------------------------
(Updated Jan. 24, 2018, 7:50 p.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
Changes
-------
Implemented suggestions from Gaston.
Bugs: MESOS-8469
https://issues.apache.org/jira/browse/MESOS-8469
Repository: mesos
Description (updated)
-------
Added test for delayed authorization during operator events.
Diffs (updated)
-----
src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94
Diff: https://reviews.apache.org/r/65316/diff/2/
Changes: https://reviews.apache.org/r/65316/diff/1-2/
Testing
-------
Confirmed that the test fails without the fix for MESOS-8469.
When the fix is included, the test passes. Successfully ran `bin/mesos-tests.sh --gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*" --gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness.
Thanks,
Greg Mann
Re: Review Request 65316: Added test for delayed authorization during
operator events.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/#review196161
-----------------------------------------------------------
src/tests/api_tests.cpp
Lines 2598-2600 (patched)
<https://reviews.apache.org/r/65316/#comment275681>
Please use this instead:
```
EXPECT_CALL(*scheduler, connected(_))
.WillOnce(v1::scheduler::SendSubscribe(v1::DEFAULT_FRAMEWORK_INFO));
```
src/tests/api_tests.cpp
Lines 2620 (patched)
<https://reviews.apache.org/r/65316/#comment275682>
You don't need this if you remove the `connected` future and make the expectation use `v1::scheduler::SendSubscribe`.
src/tests/api_tests.cpp
Lines 2742-2757 (patched)
<https://reviews.apache.org/r/65316/#comment275683>
You can use:
```
mesos.send(
v1::createCallAccept(
frameworkId,
offer,
{v1::LAUNCH({taskInfo}));
```
- Gaston Kleiman
On Jan. 24, 2018, 11:38 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65316/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2018, 11:38 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
>
>
> Bugs: MESOS-8469
> https://issues.apache.org/jira/browse/MESOS-8469
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Until the fix for MESOS-8469, it was possible for the master
> operator event stream to drop events, if event-related state in
> the master changed in between asynchronous calls.
>
> This patch adds `MasterAPITest.EventAuthorizationDelayed` to
> verify the fix for that issue.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94
>
>
> Diff: https://reviews.apache.org/r/65316/diff/1/
>
>
> Testing
> -------
>
> Confirmed that the test fails without the fix for MESOS-8469.
>
> When the fix is included, the test passes. Successfully ran `bin/mesos-tests.sh --gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*" --gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65316: Added test for delayed authorization during
operator events.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/
-----------------------------------------------------------
(Updated Jan. 24, 2018, 7:38 p.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
Bugs: MESOS-8469
https://issues.apache.org/jira/browse/MESOS-8469
Repository: mesos
Description (updated)
-------
Until the fix for MESOS-8469, it was possible for the master
operator event stream to drop events, if event-related state in
the master changed in between asynchronous calls.
This patch adds `MasterAPITest.EventAuthorizationDelayed` to
verify the fix for that issue.
Diffs
-----
src/tests/api_tests.cpp bdacc30be4dc8656a41a0c47d0e350d48e59ad94
Diff: https://reviews.apache.org/r/65316/diff/1/
Testing (updated)
-------
Confirmed that the test fails without the fix for MESOS-8469.
When the fix is included, the test passes. Successfully ran `bin/mesos-tests.sh --gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*" --gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness.
Thanks,
Greg Mann