You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/09 15:51:05 UTC

[GitHub] [fineract] thesmallstar edited a comment on pull request #990: FINERACT-821 Added and Enforced EmptyBlock Checkstyle

thesmallstar edited a comment on pull request #990:
URL: https://github.com/apache/fineract/pull/990#issuecomment-640817087


   From the guidelines -> 
   
   > Either way, including the root cause by using catch (SomeException e) and then either ..
   
   The root cause, in this case, is not an exception (If I am not wrong), we are checking the response code and then throwing an exception. It won't make much sense, in this case, to rethrow the same exception twice? or any other exception. 
   
   I hope this is a correct way 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org