You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Pierpaolo Fumagalli <ia...@iname.com> on 1998/06/22 21:57:34 UTC
[PATCH] About PR#2467
I posted PR#2467 since apache (in my environment - WinNT ) does not cleanup
the pconf pool when exiting...
This creates me some problems since in mod_jserv.c (the new module for
Java-Apache JServ 0.10.1) the cleanup functions are never called when Apache
is shutting down.
Does anyone has a better solution? (This is currently working at my place,
but you have the knowledge)... Can I keep this and feel secure about it???
Thank you...
Pier
---
*** http_main-old.c Mon Jun 22 21:50:59 1998
--- http_main.c Mon Jun 22 21:56:20 1998
***************
*** 5033,5038 ****
--- 5033,5039 ----
cleanup_scoreboard();
APD2("process PID %d exited", my_pid);
+ ap_destroy_pool(pconf);
exit(0);
} /* standalone_main */
***************
*** 5481,5486 ****
--- 5482,5488 ----
"Apache", install, run_as_service);
}
+ ap_destroy_pool(pconf);
return (0);
}
Re: [PATCH] About PR#2467
Posted by Ben Laurie <be...@algroup.co.uk>.
Pierpaolo Fumagalli wrote:
>
> I posted PR#2467 since apache (in my environment - WinNT ) does not cleanup
> the pconf pool when exiting...
> This creates me some problems since in mod_jserv.c (the new module for
> Java-Apache JServ 0.10.1) the cleanup functions are never called when Apache
> is shutting down.
> Does anyone has a better solution? (This is currently working at my place,
> but you have the knowledge)... Can I keep this and feel secure about it???
> Thank you...
Seems to me that really these should use clean_parent_exit() instead -
which comes to the same thing, of course, but is more correct.
So, yes, these are correct, AFAICS. I'm committing the "more correct"
patch now. Thanks for the input.
BTW, since we seem to deprecate the use of exit() these days, perhaps
one of my nastier kludges is indicated:
#define exit don't
Cheers,
Ben.
--
Ben Laurie |Phone: +44 (181) 735 0686| Apache Group member
Freelance Consultant |Fax: +44 (181) 735 0689|http://www.apache.org/
and Technical Director|Email: ben@algroup.co.uk |
A.L. Digital Ltd, |Apache-SSL author http://www.apache-ssl.org/
London, England. |"Apache: TDG" http://www.ora.com/catalog/apache/
WE'RE RECRUITING! http://www.aldigital.co.uk/recruit/