You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/25 16:16:34 UTC
[GitHub] [shardingsphere] mabaiwan opened a new pull request, #18593: Improve ExportDatabaseConfigurationHandler
mabaiwan opened a new pull request, #18593:
URL: https://github.com/apache/shardingsphere/pull/18593
Fixes #18437.
Changes proposed in this pull request:
- Improve ExportDatabaseConfigurationHandler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] mabaiwan commented on pull request #18593: Improve ExportDatabaseConfigurationHandler
Posted by GitBox <gi...@apache.org>.
mabaiwan commented on PR #18593:
URL: https://github.com/apache/shardingsphere/pull/18593#issuecomment-1166323740
> I am not sure whether replace with String is the only solution. It is better to use original yaml engine to generate the content.
I'll try another solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #18593: Improve ExportDatabaseConfigurationHandler
Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #18593:
URL: https://github.com/apache/shardingsphere/pull/18593#issuecomment-1166324027
Great, we can create a new issue to keep improving it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #18593: Improve ExportDatabaseConfigurationHandler
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #18593:
URL: https://github.com/apache/shardingsphere/pull/18593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org