You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by nickwallen <gi...@git.apache.org> on 2017/01/23 15:06:45 UTC
[GitHub] incubator-metron pull request #422: METRON-670 Monit Incorrectly Reports Sta...
GitHub user nickwallen opened a pull request:
https://github.com/apache/incubator-metron/pull/422
METRON-670 Monit Incorrectly Reports Status
In a constrained environment, like 'Quick Dev', Monit will often incorrectly report the status of a Metron topology. This occurs when the environment is under load and a query of topology status exceeds the default timeout of 30 seconds.
Added a parameter so that the timeout for a status check can be extended under these conditions. This was previously done for starting and stopping a topology, but not for a status checks.
This was tested in 'Quick Dev' and made starting, stopping and reporting status of the topologies using Monit work much better. Previously Monit would erroneously report some of the topologies as not running when they were. This would also interfere with your ability to start/stop the same topologies.
For example, starting all of the services required to consume Bro telemetry works much better with this change.
```
monit -g bro start
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/incubator-metron METRON-670
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/422.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #422
----
commit adf86d7f8c536d26e9d078768ad8e158fe33bbf2
Author: Nick Allen <ni...@nickallen.org>
Date: 2017-01-23T14:51:27Z
METRON-670 Monit Incorrectly Reports Status
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #422: METRON-670 Monit Incorrectly Reports Status
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/incubator-metron/pull/422
There are also problems with shutting down topologies, since we don't pass in the wait to storm ( at least we didn't. I need to find the pr/jira for that. All external calls from monit need to have clear timeout accounting from both monit's pov and the external agent
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #422: METRON-670 Monit Incorrectly Reports Status
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the issue:
https://github.com/apache/incubator-metron/pull/422
It creates a bunch of rebase conflicts for me when I bring it in. Fwiw, I've got one more hard problem + a review until I'm done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #422: METRON-670 Monit Incorrectly Reports Status
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/incubator-metron/pull/422
+1, spun this up in quick dev, and it seems to work well and the UI reports the timeout on status is 60 seconds. Thanks for grabbing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #422: METRON-670 Monit Incorrectly Reports Status
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/422
No longer needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #422: METRON-670 Monit Incorrectly Reports Status
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/incubator-metron/pull/422
I found myself having to manually do this all the time. I thought it might be worthwhile to put the fix in, so that at least we have a record of it working at some point in time. Then after @dlyle65535 gets his PR done, he can remove it.
I don't have a strong opinion either way though. Meh.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #422: METRON-670 Monit Incorrectly Reports Sta...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen closed the pull request at:
https://github.com/apache/incubator-metron/pull/422
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #422: METRON-670 Monit Incorrectly Reports Status
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the issue:
https://github.com/apache/incubator-metron/pull/422
All of these files will go away as a result of [PR-436](https://github.com/apache/incubator-metron/pull/436). Would you guys be willing to hold off until I can get it completed and through the process?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #422: METRON-670 Monit Incorrectly Reports Status
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/incubator-metron/pull/422
@dlyle65535 I'm fine with holding off on it. I wasn't sure of the timing on that, and I have been annoyed by this issue in my own testing in the interim.
@nickwallen You okay with holding off on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---