You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Radhika PC <ra...@citrix.com> on 2013/02/13 07:02:23 UTC
Review Request: Documentation on Persistent Network
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9421/
-----------------------------------------------------------
Review request for cloudstack, David Nalley, Chip Childers, Jessica Tomechak, and Joe Brockmeier.
Description
-------
Documentation changes for the feature Persistent Network. The document describes what is Persistent Networks, how to configure one, and the advantages.
This addresses bug CLOUDSTACK-852.
Diffs
-----
docs/en-US/creating-network-offerings.xml 0269ce0
docs/en-US/networks.xml a7b9ea1
docs/en-US/persistent-network.xml PRE-CREATION
Diff: https://reviews.apache.org/r/9421/diff/
Testing
-------
Patch cleanly applies. The initial tech review is done by the developer.
Build fine for both Admin and Install Guides.
Thanks,
Radhika PC
Re: Review Request: Documentation on Persistent Network
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9421/#review16504
-----------------------------------------------------------
Patch applied cleanly and has been merged with asf/master .
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/eaf7767c
Thanks !
- Pranav Saxena
On Feb. 13, 2013, 6:58 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9421/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 6:58 a.m.)
>
>
> Review request for cloudstack, David Nalley, Chip Childers, Jessica Tomechak, Likitha Shetty, and Joe Brockmeier.
>
>
> Description
> -------
>
> Documentation changes for the feature Persistent Network. The document describes what is Persistent Networks, how to configure one, and the advantages.
>
>
> This addresses bug CLOUDSTACK-852.
>
>
> Diffs
> -----
>
> docs/en-US/creating-network-offerings.xml 0269ce0
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/persistent-network.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9421/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. The initial tech review is done by the developer.
>
> Build fine for both Admin and Install Guides.
>
>
> Thanks,
>
> Radhika PC
>
>
RE: Review Request: Documentation on Persistent Network
Posted by Radhika Puthiyetath <ra...@citrix.com>.
I am saved! Thank you Pranav.
-----Original Message-----
From: Pranav Saxena [mailto:noreply@reviews.apache.org] On Behalf Of Pranav Saxena
Sent: Thursday, February 14, 2013 4:03 PM
To: Chip Childers; Joe Brockmeier; David Nalley; Likitha Shetty; Jessica Tomechak
Cc: cloudstack; Radhika Puthiyetath; Pranav Saxena
Subject: Re: Review Request: Documentation on Persistent Network
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9421/#review16574
-----------------------------------------------------------
Both patches applied cleanly on master and 4.1 . Merged with both the branches. Please mark the review request as Submitted.
4.1 - Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/64bd5f39
master - Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/26679e88
Thanks !
- Pranav Saxena
On Feb. 13, 2013, 10:03 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9421/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 10:03 a.m.)
>
>
> Review request for cloudstack, David Nalley, Chip Childers, Jessica Tomechak, Likitha Shetty, and Joe Brockmeier.
>
>
> Description
> -------
>
> Documentation changes for the feature Persistent Network. The document describes what is Persistent Networks, how to configure one, and the advantages.
>
>
> This addresses bug CLOUDSTACK-852.
>
>
> Diffs
> -----
>
> docs/en-US/creating-network-offerings.xml 0269ce0
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/persistent-network.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9421/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. The initial tech review is done by the developer.
>
> Build fine for both Admin and Install Guides.
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Documentation on Persistent Network
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9421/#review16574
-----------------------------------------------------------
Both patches applied cleanly on master and 4.1 . Merged with both the branches. Please mark the review request as Submitted.
4.1 - Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/64bd5f39
master - Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/26679e88
Thanks !
- Pranav Saxena
On Feb. 13, 2013, 10:03 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9421/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 10:03 a.m.)
>
>
> Review request for cloudstack, David Nalley, Chip Childers, Jessica Tomechak, Likitha Shetty, and Joe Brockmeier.
>
>
> Description
> -------
>
> Documentation changes for the feature Persistent Network. The document describes what is Persistent Networks, how to configure one, and the advantages.
>
>
> This addresses bug CLOUDSTACK-852.
>
>
> Diffs
> -----
>
> docs/en-US/creating-network-offerings.xml 0269ce0
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/persistent-network.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9421/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. The initial tech review is done by the developer.
>
> Build fine for both Admin and Install Guides.
>
>
> Thanks,
>
> Radhika PC
>
>
RE: Review Request: Documentation on Persistent Network
Posted by Animesh Chaturvedi <an...@citrix.com>.
Committer that are on the review list if this looks good please submit the patch and bring this patch to closure
> -----Original Message-----
> From: Radhika PC [mailto:noreply@reviews.apache.org] On Behalf Of Radhika
> PC
> Sent: Wednesday, February 13, 2013 2:04 AM
> To: Chip Childers; Joe Brockmeier; David Nalley; Likitha Shetty; Jessica
> Tomechak
> Cc: cloudstack; Radhika Puthiyetath; Pranav Saxena
> Subject: Re: Review Request: Documentation on Persistent Network
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9421/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 10:03 a.m.)
>
>
> Review request for cloudstack, David Nalley, Chip Childers, Jessica Tomechak,
> Likitha Shetty, and Joe Brockmeier.
>
>
> Changes
> -------
>
> 1. Updated the diff. This new patch should not break the build. I added a
> conditional tag to creating-network-offerings.xml file so that it would not break
> install guide. This section is not part of the Install Guide on the master. Need to
> fix. I tested my changes against the wrong set of Install guide files, which
> showed that the doc builds just fine! Mistake from my part.
>
> 2. Created a new patch against 4.1 branch, mainly because the creating-
> network-offerings.xml is different on 4.1. There are many changes went into
> 4.1 but not on master. Please merge in master. Please make sure that my
> changes are not over-written.
>
> Sorry Pranav for the double work. Thanks Rohit for reporting the issue
>
>
> Description
> -------
>
> Documentation changes for the feature Persistent Network. The document
> describes what is Persistent Networks, how to configure one, and the
> advantages.
>
>
> This addresses bug CLOUDSTACK-852.
>
>
> Diffs (updated)
> -----
>
> docs/en-US/creating-network-offerings.xml 0269ce0
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/persistent-network.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9421/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. The initial tech review is done by the developer.
>
> Build fine for both Admin and Install Guides.
>
>
> Thanks,
>
> Radhika PC
Re: Review Request: Documentation on Persistent Network
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9421/
-----------------------------------------------------------
(Updated Feb. 13, 2013, 10:03 a.m.)
Review request for cloudstack, David Nalley, Chip Childers, Jessica Tomechak, Likitha Shetty, and Joe Brockmeier.
Changes
-------
1. Updated the diff. This new patch should not break the build. I added a conditional tag to creating-network-offerings.xml file so that it would not break install guide. This section is not part of the Install Guide on the master. Need to fix. I tested my changes against the wrong set of Install guide files, which showed that the doc builds just fine! Mistake from my part.
2. Created a new patch against 4.1 branch, mainly because the creating-network-offerings.xml is different on 4.1. There are many changes went into 4.1 but not on master. Please merge in master. Please make sure that my changes are not over-written.
Sorry Pranav for the double work. Thanks Rohit for reporting the issue
Description
-------
Documentation changes for the feature Persistent Network. The document describes what is Persistent Networks, how to configure one, and the advantages.
This addresses bug CLOUDSTACK-852.
Diffs (updated)
-----
docs/en-US/creating-network-offerings.xml 0269ce0
docs/en-US/networks.xml a7b9ea1
docs/en-US/persistent-network.xml PRE-CREATION
Diff: https://reviews.apache.org/r/9421/diff/
Testing
-------
Patch cleanly applies. The initial tech review is done by the developer.
Build fine for both Admin and Install Guides.
Thanks,
Radhika PC
Re: Review Request: Documentation on Persistent Network
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9421/#review16507
-----------------------------------------------------------
Sorry , not able to apply your patch cleanly on 4.1 because of this -
error: patch failed: docs/en-US/creating-network-offerings.xml:22
error: docs/en-US/creating-network-offerings.xml: patch does not apply
could you please check ?
Thanks!
- Pranav Saxena
On Feb. 13, 2013, 8:18 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9421/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 8:18 a.m.)
>
>
> Review request for cloudstack, David Nalley, Chip Childers, Jessica Tomechak, Likitha Shetty, and Joe Brockmeier.
>
>
> Description
> -------
>
> Documentation changes for the feature Persistent Network. The document describes what is Persistent Networks, how to configure one, and the advantages.
>
>
> This addresses bug CLOUDSTACK-852.
>
>
> Diffs
> -----
>
> docs/en-US/creating-network-offerings.xml 0269ce0
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/persistent-network.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9421/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. The initial tech review is done by the developer.
>
> Build fine for both Admin and Install Guides.
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Documentation on Persistent Network
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9421/
-----------------------------------------------------------
(Updated Feb. 13, 2013, 8:18 a.m.)
Review request for cloudstack, David Nalley, Chip Childers, Jessica Tomechak, Likitha Shetty, and Joe Brockmeier.
Changes
-------
created a patch purely for 4.1 branch.
Description
-------
Documentation changes for the feature Persistent Network. The document describes what is Persistent Networks, how to configure one, and the advantages.
This addresses bug CLOUDSTACK-852.
Diffs
-----
docs/en-US/creating-network-offerings.xml 0269ce0
docs/en-US/networks.xml a7b9ea1
docs/en-US/persistent-network.xml PRE-CREATION
Diff: https://reviews.apache.org/r/9421/diff/
Testing
-------
Patch cleanly applies. The initial tech review is done by the developer.
Build fine for both Admin and Install Guides.
Thanks,
Radhika PC
Re: Review Request: Documentation on Persistent Network
Posted by Radhika PC <ra...@citrix.com>.
> On Feb. 13, 2013, 7:54 a.m., Pranav Saxena wrote:
> > Tried to cherry pick the same commit to 4.1 but it gives a merge conflict in networkOfferings.xml file. Could you please resolve them and send an updated patch for asf/4.1 .
> >
> > Regards,
> > Pranav
Jessica had some commit on the 4.1 branch (on the file creating-network-offering.xml)because of which there was a merge conflict. I am attaching a new patch taken against 4.1 branch is attaching. Please merge.
- Radhika
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9421/#review16505
-----------------------------------------------------------
On Feb. 13, 2013, 8:18 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9421/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 8:18 a.m.)
>
>
> Review request for cloudstack, David Nalley, Chip Childers, Jessica Tomechak, Likitha Shetty, and Joe Brockmeier.
>
>
> Description
> -------
>
> Documentation changes for the feature Persistent Network. The document describes what is Persistent Networks, how to configure one, and the advantages.
>
>
> This addresses bug CLOUDSTACK-852.
>
>
> Diffs
> -----
>
> docs/en-US/creating-network-offerings.xml 0269ce0
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/persistent-network.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9421/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. The initial tech review is done by the developer.
>
> Build fine for both Admin and Install Guides.
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Documentation on Persistent Network
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9421/#review16505
-----------------------------------------------------------
Tried to cherry pick the same commit to 4.1 but it gives a merge conflict in networkOfferings.xml file. Could you please resolve them and send an updated patch for asf/4.1 .
Regards,
Pranav
- Pranav Saxena
On Feb. 13, 2013, 6:58 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9421/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 6:58 a.m.)
>
>
> Review request for cloudstack, David Nalley, Chip Childers, Jessica Tomechak, Likitha Shetty, and Joe Brockmeier.
>
>
> Description
> -------
>
> Documentation changes for the feature Persistent Network. The document describes what is Persistent Networks, how to configure one, and the advantages.
>
>
> This addresses bug CLOUDSTACK-852.
>
>
> Diffs
> -----
>
> docs/en-US/creating-network-offerings.xml 0269ce0
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/persistent-network.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9421/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. The initial tech review is done by the developer.
>
> Build fine for both Admin and Install Guides.
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Documentation on Persistent Network
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9421/
-----------------------------------------------------------
(Updated Feb. 13, 2013, 6:58 a.m.)
Review request for cloudstack, David Nalley, Chip Childers, Jessica Tomechak, Likitha Shetty, and Joe Brockmeier.
Changes
-------
missed to included the owner of the feature to the reviewer list.
Description
-------
Documentation changes for the feature Persistent Network. The document describes what is Persistent Networks, how to configure one, and the advantages.
This addresses bug CLOUDSTACK-852.
Diffs
-----
docs/en-US/creating-network-offerings.xml 0269ce0
docs/en-US/networks.xml a7b9ea1
docs/en-US/persistent-network.xml PRE-CREATION
Diff: https://reviews.apache.org/r/9421/diff/
Testing
-------
Patch cleanly applies. The initial tech review is done by the developer.
Build fine for both Admin and Install Guides.
Thanks,
Radhika PC
Re: Review Request: Documentation on Persistent Network
Posted by Likitha Shetty <li...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9421/#review16503
-----------------------------------------------------------
Ship it!
Applies cleanly on master
- Likitha Shetty
On Feb. 13, 2013, 6:02 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9421/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 6:02 a.m.)
>
>
> Review request for cloudstack, David Nalley, Chip Childers, Jessica Tomechak, and Joe Brockmeier.
>
>
> Description
> -------
>
> Documentation changes for the feature Persistent Network. The document describes what is Persistent Networks, how to configure one, and the advantages.
>
>
> This addresses bug CLOUDSTACK-852.
>
>
> Diffs
> -----
>
> docs/en-US/creating-network-offerings.xml 0269ce0
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/persistent-network.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9421/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. The initial tech review is done by the developer.
>
> Build fine for both Admin and Install Guides.
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Documentation on Persistent Network
Posted by Likitha Shetty <li...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9421/#review16502
-----------------------------------------------------------
Content looks good to me.
- Likitha Shetty
On Feb. 13, 2013, 6:02 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9421/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 6:02 a.m.)
>
>
> Review request for cloudstack, David Nalley, Chip Childers, Jessica Tomechak, and Joe Brockmeier.
>
>
> Description
> -------
>
> Documentation changes for the feature Persistent Network. The document describes what is Persistent Networks, how to configure one, and the advantages.
>
>
> This addresses bug CLOUDSTACK-852.
>
>
> Diffs
> -----
>
> docs/en-US/creating-network-offerings.xml 0269ce0
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/persistent-network.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9421/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. The initial tech review is done by the developer.
>
> Build fine for both Admin and Install Guides.
>
>
> Thanks,
>
> Radhika PC
>
>