You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commonsrdf.apache.org by st...@apache.org on 2016/10/28 10:34:35 UTC
[05/12] incubator-commonsrdf git commit: JavaDoc and 'protected' for
abstract test methods
JavaDoc and 'protected' for abstract test methods
Project: http://git-wip-us.apache.org/repos/asf/incubator-commonsrdf/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-commonsrdf/commit/e340604b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-commonsrdf/tree/e340604b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-commonsrdf/diff/e340604b
Branch: refs/heads/COMMONSRDF-46
Commit: e340604bb4bd00665494706c7535a34fba59f51e
Parents: 7779fca
Author: Stian Soiland-Reyes <st...@apache.org>
Authored: Fri Oct 28 10:55:40 2016 +0100
Committer: Stian Soiland-Reyes <st...@apache.org>
Committed: Fri Oct 28 10:55:40 2016 +0100
----------------------------------------------------------------------
.../apache/commons/rdf/api/AbstractBlankNodeTest.java | 8 ++++++++
.../org/apache/commons/rdf/api/AbstractGraphTest.java | 9 ++++++++-
.../commons/rdf/api/AbstractRDFTermFactoryTest.java | 12 ++++++------
3 files changed, 22 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-commonsrdf/blob/e340604b/api/src/test/java/org/apache/commons/rdf/api/AbstractBlankNodeTest.java
----------------------------------------------------------------------
diff --git a/api/src/test/java/org/apache/commons/rdf/api/AbstractBlankNodeTest.java b/api/src/test/java/org/apache/commons/rdf/api/AbstractBlankNodeTest.java
index 1556a03..b61c64a 100644
--- a/api/src/test/java/org/apache/commons/rdf/api/AbstractBlankNodeTest.java
+++ b/api/src/test/java/org/apache/commons/rdf/api/AbstractBlankNodeTest.java
@@ -27,6 +27,14 @@ import static org.junit.Assert.assertNotEquals;
*/
public abstract class AbstractBlankNodeTest {
+ /**
+ * This method must be overridden by the implementing test to
+ * create a {@link BlankNode} to be tested.
+ * <p>
+ * Each call to this method must provide a new, unique BlankNode.
+ *
+ * @return {@link RDF} instance to be tested.
+ */
protected abstract BlankNode getBlankNode();
/**
http://git-wip-us.apache.org/repos/asf/incubator-commonsrdf/blob/e340604b/api/src/test/java/org/apache/commons/rdf/api/AbstractGraphTest.java
----------------------------------------------------------------------
diff --git a/api/src/test/java/org/apache/commons/rdf/api/AbstractGraphTest.java b/api/src/test/java/org/apache/commons/rdf/api/AbstractGraphTest.java
index ba930eb..422e97b 100644
--- a/api/src/test/java/org/apache/commons/rdf/api/AbstractGraphTest.java
+++ b/api/src/test/java/org/apache/commons/rdf/api/AbstractGraphTest.java
@@ -67,7 +67,14 @@ public abstract class AbstractGraphTest {
protected Literal companyName;
protected Triple bobNameTriple;
- public abstract RDF createFactory();
+ /**
+ *
+ * This method must be overridden by the implementing test to provide a
+ * factory for the test to create {@link Graph}, {@link IRI} etc.
+ *
+ * @return {@link RDF} instance to be tested.
+ */
+ protected abstract RDF createFactory();
@Before
public void createGraphAndAdd() {
http://git-wip-us.apache.org/repos/asf/incubator-commonsrdf/blob/e340604b/api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTermFactoryTest.java
----------------------------------------------------------------------
diff --git a/api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTermFactoryTest.java b/api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTermFactoryTest.java
index 35eb764..1ef5b6c 100644
--- a/api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTermFactoryTest.java
+++ b/api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTermFactoryTest.java
@@ -42,13 +42,13 @@ public abstract class AbstractRDFTermFactoryTest {
private RDF factory;
/**
- * testCreate a new, distinct {@link RDF} object using the
- * implementation being tested here.
- *
- * @return a new, distinct {@link RDF} object using the
- * implementation being tested here
+ *
+ * This method must be overridden by the implementing test to provide a
+ * factory for the test to create {@link Literal}, {@link IRI} etc.
+ *
+ * @return {@link RDF} instance to be tested.
*/
- public abstract RDF createFactory();
+ protected abstract RDF createFactory();
@Before
public void setUp() {