[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5909: Quota custom tariffs

[GitBox <gi...@apache.org>]

GutoVeronezi commented on a change in pull request #5909:
URL: https://github.com/apache/cloudstack/pull/5909#discussion_r817070714



##########
File path: framework/quota/src/test/java/org/apache/cloudstack/quota/constant/QuotaTypesTest.java
##########
@@ -43,6 +43,6 @@ public void testQuotaTypesList() {
     @Test
     public void testQuotaTypeDescription() {
         assertNull(QuotaTypes.getDescription(-1));
-        assertNotNull(QuotaTypes.getDescription(QuotaTypes.MEMORY));
+        assertNotNull(QuotaTypes.getDescription(QuotaTypes.VOLUME));

Review comment:
       @DaanHoogland this type does not exist anymore. As described in the spec (#5891), in this proposal the tariffs will be custom, so instead of having one tariff type for each VM resource, the values will be injected as preset variables into the RUNNING_VM resource, allowing operators to charge them. The current vCPU, CPU_SPEED and MEMORY tariffs will be converted to RUNNING_VM tariffs with respective activation rules and their types will be removed from ACS.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org