You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by eiri <gi...@git.apache.org> on 2015/09/21 04:14:25 UTC
[GitHub] couchdb-couch-log pull request: Recognize rebar templater's list f...
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch-log/pull/5
Recognize rebar templater's list format
Rebar's templater uses tagged tuples to accept lists in .script files. This fix makes `couch_log.app` script to recognize this convention.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch-log fix-appscript-list-resolution
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-log/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
commit 2af3ffab250e79a05bc76c6ccf41827fcbd7e6ea
Author: Eric Avdey <ei...@eiri.ca>
Date: 2015-09-21T02:11:20Z
Recognise rebar templater's list format
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-log pull request: Recognize rebar templater's list f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch-log/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-log pull request: Recognize rebar templater's list f...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-log/pull/5#discussion_r39955592
--- Diff: src/couch_log.app.src.script ---
@@ -26,6 +26,8 @@ Backend = case lists:keyfind(couch_log_backend, 1, CouchConfig) of
end.
BackendApps = case lists:keyfind(couch_log_backend_apps, 1, CouchConfig) of
+ {couch_log_backend_apps, {list, Apps}} ->
+ Apps;
{couch_log_backend_apps, Apps} ->
--- End diff --
remove the non list clause?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-log pull request: Recognize rebar templater's list f...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-log/pull/5#issuecomment-141930016
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---