[GitHub] [pulsar] thetumbled commented on a diff in pull request #17009: [fix][transaction] Correct the prompt message

[GitBox <gi...@apache.org>]

thetumbled commented on code in PR #17009:
URL: https://github.com/apache/pulsar/pull/17009#discussion_r1005129050


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java:
##########
@@ -181,7 +181,7 @@ private void addIndividualAcknowledgeMessageRequest(TxnID txnID,
     public void internalIndividualAcknowledgeMessage(TxnID txnID, List<MutablePair<PositionImpl, Integer>> positions,
                                                      CompletableFuture<Void> completableFuture) {
         if (txnID == null) {
-            completableFuture.completeExceptionally(new NotAllowedException("Positions can not be null."));
+            completableFuture.completeExceptionally(new NotAllowedException("txnID can not be null."));

Review Comment:
   The condition checks if txnID is null, not the Positions, isn't it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org