You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/06/22 14:07:14 UTC

[GitHub] [solr] risdenk commented on a diff in pull request #912: WIP - Use up to JDK 11 features

risdenk commented on code in PR #912:
URL: https://github.com/apache/solr/pull/912#discussion_r903793244


##########
solr/core/src/java/org/apache/solr/filestore/PackageStoreAPI.java:
##########
@@ -212,12 +212,10 @@ public void upload(SolrQueryRequest req, SolrQueryResponse rsp) {
         } catch (IOException e) {
           throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, e);
         }
-      } catch (InterruptedException e) {
-        log.error("Unexpected error", e);
       } catch (KeeperException.NodeExistsException e) {
         throw new SolrException(
             SolrException.ErrorCode.SERVER_ERROR, "A write is already in process , try later");
-      } catch (KeeperException e) {
+      } catch (InterruptedException | KeeperException e) {

Review Comment:
   Thanks yea I noticed this as well. You are quick to review  :) - I threw it up so I could more easily look at the changes too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org