You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org> on 2006/06/09 00:17:30 UTC

[jira] Created: (ADFFACES-19) SKINNING: Selector is skipped if there is a space immediately after the open brace.

SKINNING: Selector is skipped if there is a space immediately after the open brace.
-----------------------------------------------------------------------------------

         Key: ADFFACES-19
         URL: http://issues.apache.org/jira/browse/ADFFACES-19
     Project: MyFaces ADF-Faces
        Type: Bug

    Reporter: Jeanne Waldman
    Priority: Minor


To reproduce, go the the purpleSkin.css file and add a selector and
properties like this:

 .SomeSelector
{
   font-size: 10pt;
   color: red;
}

When you run any component demo, you should be able to look at the generated
css file and see this selector. This is the expected result.
However, if you put a ' ' (a space) after the opening {, you won't see this
selector in the generated css file. This is the actual result, and the bug.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (ADFFACES-19) SKINNING: Selector is skipped if there is a space immediately after the open brace.

Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
    [ http://issues.apache.org/jira/browse/ADFFACES-19?page=comments#action_12415453 ] 

Jeanne Waldman commented on ADFFACES-19:
----------------------------------------

I'm looking into this one.

> SKINNING: Selector is skipped if there is a space immediately after the open brace.
> -----------------------------------------------------------------------------------
>
>          Key: ADFFACES-19
>          URL: http://issues.apache.org/jira/browse/ADFFACES-19
>      Project: MyFaces ADF-Faces
>         Type: Bug

>     Reporter: Jeanne Waldman
>     Priority: Minor

>
> To reproduce, go the the purpleSkin.css file and add a selector and
> properties like this:
>  .SomeSelector
> {
>    font-size: 10pt;
>    color: red;
> }
> When you run any component demo, you should be able to look at the generated
> css file and see this selector. This is the expected result.
> However, if you put a ' ' (a space) after the opening {, you won't see this
> selector in the generated css file. This is the actual result, and the bug.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (ADFFACES-19) SKINNING: Selector is skipped if there is a space immediately after the open brace.

Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
    [ http://issues.apache.org/jira/browse/ADFFACES-19?page=comments#action_12415613 ] 

Jeanne Waldman commented on ADFFACES-19:
----------------------------------------

The patch to ADFFACES-20 fixes this problem as well, since they are in the same file, SkinCSSParser.java. This fix involved changing the parser to pass through to the default switch statement when we are within a left brace, which means we are in the properties of a selector.

> SKINNING: Selector is skipped if there is a space immediately after the open brace.
> -----------------------------------------------------------------------------------
>
>          Key: ADFFACES-19
>          URL: http://issues.apache.org/jira/browse/ADFFACES-19
>      Project: MyFaces ADF-Faces
>         Type: Bug

>     Reporter: Jeanne Waldman
>     Priority: Minor

>
> To reproduce, go the the purpleSkin.css file and add a selector and
> properties like this:
>  .SomeSelector
> {
>    font-size: 10pt;
>    color: red;
> }
> When you run any component demo, you should be able to look at the generated
> css file and see this selector. This is the expected result.
> However, if you put a ' ' (a space) after the opening {, you won't see this
> selector in the generated css file. This is the actual result, and the bug.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (ADFFACES-19) SKINNING: Selector is skipped if there is a space immediately after the open brace.

Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-19?page=all ]

Matthias Weßendorf reassigned ADFFACES-19:
------------------------------------------

    Assign To: Matthias Weßendorf

> SKINNING: Selector is skipped if there is a space immediately after the open brace.
> -----------------------------------------------------------------------------------
>
>          Key: ADFFACES-19
>          URL: http://issues.apache.org/jira/browse/ADFFACES-19
>      Project: MyFaces ADF-Faces
>         Type: Bug

>     Reporter: Jeanne Waldman
>     Assignee: Matthias Weßendorf
>     Priority: Minor

>
> To reproduce, go the the purpleSkin.css file and add a selector and
> properties like this:
>  .SomeSelector
> {
>    font-size: 10pt;
>    color: red;
> }
> When you run any component demo, you should be able to look at the generated
> css file and see this selector. This is the expected result.
> However, if you put a ' ' (a space) after the opening {, you won't see this
> selector in the generated css file. This is the actual result, and the bug.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (ADFFACES-19) SKINNING: Selector is skipped if there is a space immediately after the open brace.

Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/ADFFACES-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf updated ADFFACES-19:
---------------------------------------

        Fix Version/s: 1.0.0-incubating-core
    Affects Version/s: 1.0.0-incubating-core

> SKINNING: Selector is skipped if there is a space immediately after the open brace.
> -----------------------------------------------------------------------------------
>
>                 Key: ADFFACES-19
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-19
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>    Affects Versions: 1.0.0-incubating-core
>            Reporter: Jeanne Waldman
>         Assigned To: Matthias Weßendorf
>            Priority: Minor
>             Fix For: 1.0.0-incubating-core
>
>
> To reproduce, go the the purpleSkin.css file and add a selector and
> properties like this:
>  .SomeSelector
> {
>    font-size: 10pt;
>    color: red;
> }
> When you run any component demo, you should be able to look at the generated
> css file and see this selector. This is the expected result.
> However, if you put a ' ' (a space) after the opening {, you won't see this
> selector in the generated css file. This is the actual result, and the bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (ADFFACES-19) SKINNING: Selector is skipped if there is a space immediately after the open brace.

Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-19?page=all ]
     
Matthias Weßendorf closed ADFFACES-19:
--------------------------------------

    Resolution: Fixed

applied patch from Jeanne Waldman.

> SKINNING: Selector is skipped if there is a space immediately after the open brace.
> -----------------------------------------------------------------------------------
>
>          Key: ADFFACES-19
>          URL: http://issues.apache.org/jira/browse/ADFFACES-19
>      Project: MyFaces ADF-Faces
>         Type: Bug

>     Reporter: Jeanne Waldman
>     Assignee: Matthias Weßendorf
>     Priority: Minor

>
> To reproduce, go the the purpleSkin.css file and add a selector and
> properties like this:
>  .SomeSelector
> {
>    font-size: 10pt;
>    color: red;
> }
> When you run any component demo, you should be able to look at the generated
> css file and see this selector. This is the expected result.
> However, if you put a ' ' (a space) after the opening {, you won't see this
> selector in the generated css file. This is the actual result, and the bug.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira