[jira] [Commented] (PHOENIX-2999) Upgrading Multi-tenant table to map with namespace using upgradeUtil

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362060#comment-15362060 ] 

Hadoop QA commented on PHOENIX-2999:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12816130/PHOENIX-2999_v4.patch
  against master branch at commit 5570a73ffd5e73ca6afef302d8f025665f40c9db.
  ATTACHMENT ID: 12816130

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 34 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +            Map<String, Set<String>> tenantViewNames = MetaDataUtil.getTenantViewNames(phxConn, phoenixFullTableName);
+                phxConn = DriverManager.getConnection(getUrl(), props).unwrap(PhoenixConnection.class);
+    public void testMapMultiTenantTableToNamespaceDuringUpgrade() throws SQLException, SnapshotCreationException,
+        String hbaseTableName = SchemaUtil.getPhysicalTableName(Bytes.toBytes(phoenixFullTableName), true)
+                    + "(k VARCHAR not null, v INTEGER not null, f INTEGER, g INTEGER NULL, h INTEGER NULL CONSTRAINT pk PRIMARY KEY(k,v)) MULTI_TENANT=true");
+                    .prepareStatement("UPSERT INTO " + phoenixFullTableName + " VALUES(?, ?, 0, 0, 0)");
+            conn.createStatement().execute("create index " + indexName + " on " + phoenixFullTableName + "(f)");
+            conn.createStatement().execute("CREATE VIEW diff.v (col VARCHAR) AS SELECT * FROM " + phoenixFullTableName);
+            conn.createStatement().execute("CREATE VIEW test.v (col VARCHAR) AS SELECT * FROM " + phoenixFullTableName);
+            conn.createStatement().execute("CREATE VIEW v (col VARCHAR) AS SELECT * FROM " + phoenixFullTableName);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PhoenixRuntimeIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/424//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/424//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/424//console

This message is automatically generated.

> Upgrading Multi-tenant table to map with namespace using upgradeUtil
> --------------------------------------------------------------------
>
>                 Key: PHOENIX-2999
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2999
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.8.0
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Critical
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2999.patch, PHOENIX-2999_v1.patch, PHOENIX-2999_v2.patch, PHOENIX-2999_v3.patch, PHOENIX-2999_v4.patch
>
>
> currently upgradeUtil doesn't handle multi-tenant table with tenant views properly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)